Nether Portal Jumping & Creation Code

[lkolbly]

Per #1856, this code implements a portal scanner which finds and creates nether portals when entities move between the overworld and the nether.

It also changes dae9e57#diff-97bcf8a96a22aec81982926aa1462363R298 because StringToInteger returns true if the conversion was successful. I think.

[madmaxoft]

Please try to use the same coding style. We use a space after all commas, and a space around pointer and reference declarations (cWorld * a_World etc.) There's too many of these to report each one. Unfortunately the basic stylechecking script cannot detect these reliably, so you'll need to do it by hand.

[madmaxoft]

Please try to use the same coding style. We use a space after all commas, and a space around pointer and reference declarations (cWorld * a_World etc.) There's too many of these to report each one. Unfortunately the basic stylechecking script cannot detect these reliably, so you'll need to do it by hand.

[lkolbly]

Okay, I'll go back through as I move it to a new file.

[lkolbly]

Okay, I'll go back through as I move it to a new file.

[lkolbly]

Okay, I think I got it compliant with the coding convention in bad47a8, except maybe local variable names, I don't know what the convention is for those. I didn't see any commas without spaces, though, so I'm probably looking at the wrong commas?

[lkolbly]

Okay, I think I got it compliant with the coding convention in bad47a8, except maybe local variable names, I don't know what the convention is for those. I didn't see any commas without spaces, though, so I'm probably looking at the wrong commas?

[lkolbly]

What's the preferred way to convert between Vector types, e.g. from Vector3i to a Vector3d?

[lkolbly]

What's the preferred way to convert between Vector types, e.g. from Vector3i to a Vector3d?

[madmaxoft]

I don't think there's any preference. There's a simple copy-constructor provided within the vector template, and for converting to a Vector3i there's also the Floor() function defined on the class (Ceil() is missing right now, but could be added with minimal effort).

[madmaxoft]

I don't think there's any preference. There's a simple copy-constructor provided within the vector template, and for converting to a Vector3i there's also the Floor() function defined on the class (Ceil() is missing right now, but could be added with minimal effort).

[lkolbly]

Okay. I think I've fixed the convention errors.

[lkolbly]

Okay. I think I've fixed the convention errors.

[lkolbly]

Alright, I just refactored m_Dir to use a Direction type which is either X or Y (I considered NORTH_SOUTH and EAST_WEST, but that didn't seem to map to the code as well).

[lkolbly]

Alright, I just refactored m_Dir to use a Direction type which is either X or Y (I considered NORTH_SOUTH and EAST_WEST, but that didn't seem to map to the code as well).

[madmaxoft]

Is there any chance you could get this rebased onto current master and squashed into a single commit?

[madmaxoft]

Is there any chance you could get this rebased onto current master and squashed into a single commit?

[lkolbly]

Sure thing. Done.

[lkolbly]

Sure thing. Done.

[madmaxoft]

I think this is merge-worthy. Opinions?

[madmaxoft]

I think this is merge-worthy. Opinions?

[NiLSPACE]

Apart from the question I have about the m_IsWorldChangeScheduled initialization it looks really good.

[NiLSPACE]

Apart from the question I have about the m_IsWorldChangeScheduled initialization it looks really good.

[ghost]

Please add yourself to the contributors file.

[ghost]

Please add yourself to the contributors file.

[sphinxc0re]

Looks like it's ready for merge

[sphinxc0re]

Looks like it's ready for merge

[NiLSPACE]

After almost a month I finally updated my MCServer and tried this, and I noticed that when teleporting to an portal I get teleported 1 block next to it. That probably isn't intended right? You're supposed to teleport in another portal.

EDIT:
I also noticed that if I create a portal on the top of the nether, go through it, and then go back in the portal I get teleported to the top of the nether. Vanilla doesn't allow this to happen.

[NiLSPACE]

After almost a month I finally updated my MCServer and tried this, and I noticed that when teleporting to an portal I get teleported 1 block next to it. That probably isn't intended right? You're supposed to teleport in another portal.

EDIT:
I also noticed that if I create a portal on the top of the nether, go through it, and then go back in the portal I get teleported to the top of the nether. Vanilla doesn't allow this to happen.

[sphinxc0re]

Also, you get teleported instantly but I think this is another issue

[sphinxc0re]

Also, you get teleported instantly but I think this is another issue

[NiLSPACE]

That's only in creative gamemode right? Because in vanilla you also get teleported instantly in creative mode.

[NiLSPACE]

That's only in creative gamemode right? Because in vanilla you also get teleported instantly in creative mode.

[NiLSPACE]

Looking at this again, shouldn't this be i += 2 as suggested by @madmaxoft here? It would speed up the search for a nether portal by quite allot since it wouldn't have to check every block in the chunk.

[lkolbly]

Because of the way the chunks are stored (XZY?), doing i+2 here would result in a pattern that skips every other row. Note that it's iterating from 0 to NumBlocks, not 0 to 16 each axis - this results in a speedup in not having to call CoordinateToIndex.

[madmaxoft]

It would have been possible to have two loops, the inner one iterating over the 256 blocks in a single Y slice, and the outer one iterating over Y slices, skipping 2 slices out of each 3:

for (unsigned y = 0; y < cChunkDef::Height; y += 3)
{
  unsigned BaseY = cChunkDef::Width * cChunkDef::Width * y;
  for (unsigned i = 0; i < 256; i++)
  {
    // Check block at index [BaseY + i]
  }
}

[ghost]

I tested this, I can not get back to the world from the nether trough the portal. Used the FAQ for creating a nether world.

[ghost]

I tested this, I can not get back to the world from the nether trough the portal. Used the FAQ for creating a nether world.

[NiLSPACE]

That's probably because you haven't configured the world linking in the world.ini. The FAQ only describes how you can generate such a world.

[NiLSPACE]

That's probably because you haven't configured the world linking in the world.ini. The FAQ only describes how you can generate such a world.

[sphinxc0re]

Yes, this is a problem. You have to stand right in the portal to teleport. in vanilla you only need partial contact with the portal.

Also, you are getting damage for travelling to the nether

[sphinxc0re]

Yes, this is a problem. You have to stand right in the portal to teleport. in vanilla you only need partial contact with the portal.

Also, you are getting damage for travelling to the nether

[tigerw]

Yes, this is a problem. You have to stand right in the portal to teleport. in vanilla you only need partial contact with the portal.

This is to do with lack of bounding box detection in MCS at the present.

[tigerw]

Yes, this is a problem. You have to stand right in the portal to teleport. in vanilla you only need partial contact with the portal.

This is to do with lack of bounding box detection in MCS at the present.

[lkolbly]

@NiLSPACE

... and I noticed that when teleporting to an portal I get teleported 1 block next to it.

That was intended, but can be changed easily.

[lkolbly]

@NiLSPACE

... and I noticed that when teleporting to an portal I get teleported 1 block next to it.

That was intended, but can be changed easily.

[NiLSPACE]

I think it should be changed, because I got teleported in the portal frame once. It could also be possible to be teleported inside a wall if the portal is next to it.

[NiLSPACE]

I think it should be changed, because I got teleported in the portal frame once. It could also be possible to be teleported inside a wall if the portal is next to it.

[lkolbly]

I'm not sure you can since it places the portal in a 3x4x5 empty space, so there's always air on either side of the portal. But I can change it anyway.

[lkolbly]

I'm not sure you can since it places the portal in a 3x4x5 empty space, so there's always air on either side of the portal. But I can change it anyway.

[NiLSPACE]

But if I build a portal against a wall then there isn't an empty space around it. ^^

[NiLSPACE]

But if I build a portal against a wall then there isn't an empty space around it. ^^

[lkolbly]

Oh, that's true. I hadn't thought about manually created portals. I will change that & the Y limit and make a PR after #2237 is closed. Having multiple forks is so much effort.

[lkolbly]

Oh, that's true. I hadn't thought about manually created portals. I will change that & the Y limit and make a PR after #2237 is closed. Having multiple forks is so much effort.