Work on NetherPortalScanner. Setup portal scanner to reset PortalCool… #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down. Changed where player is spawned. Added a_InitSpawn flag to CreateAndInitializeWorld.
|
Could I get a yay/nay on this please? |
worktycho
added a commit
that referenced
this pull request
Jun 26, 2015
Work on NetherPortalScanner. Setup portal scanner to reset PortalCool…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…down. Changed where player is spawned. Added a_InitSpawn flag to CreateAndInitializeWorld.
The CreateAndInitializeWorld flag was created because as far as I know, the Nether does not require a spawn area (correct me if I'm wrong, this seems like a big but valid assumption to me). DetectPortal sends a player respawn packet, but this packet is not actually sent until DetectPortal returns, which is after CreateAndInitializeWorld is called. Creating a spawn area is time-consuming, so sometimes the packet can be delayed for a while (many seconds).
This PR also contains minor stylistic changes to some comments I found. Also ScheduleMoveToWorld can set the PortalCooldown. Also actually checks the MaxY limit.