Implement aging + breeding #2696

Gargaj · 2015-11-29T18:20:19Z

Notes:

Tested and works with pigs, sheep, cows/mooshrooms, rabbits and chicken
Works with ocelots although taming for ocelots isn't implemented yet.
Doesn't work yet with wolves: they are not a passive but a neutral mob. This was an oversight in my part, but I didn't want to move the behaviour into cMonster just yet because it would introduce a whole new set of problems.
Horses need taming first and that behaviour seems dodgy / broken, so I didn't yet try that.

Another important note: There's a change in the 1.8 protocol implementation when it comes to communicating age: @rom1504 and I did a bit of snooping in the less-documented parts of the protocol (http://wiki.vg/Entities#Ageable) and found out that the only way to make the love-mode hearts disappear is to set the Age to x>0. This introduces 3 distinct states for Age: x<0 when baby, x==0 when adult and ready for mating, x>0 when exhausted from mating.

Gargaj · 2015-11-29T19:30:43Z

/cc @SafwatHalaby

SafwatHalaby · 2015-11-29T21:05:57Z

Minor remark: At https://github.com/Gargaj/cuberite/blob/breeding/src/World.cpp#L3485
It's probably best to have it that way:

if (a_Baby)
{
    Monster->SetAge(-1);
}
else
{
   mob->StopAgingTimer();
}

Gargaj · 2015-11-29T21:07:17Z

Probably true, although in the grand scheme of things it doesn't change much if it spawns as an adult, it just counts the aging timer down and then doesn't do anything.

SafwatHalaby · 2015-11-29T21:15:53Z

True as of now. But the value may be used in the future in ways we can't anticipate. Suppose some Lua API wants to query how long it'd take for a mob to grow up. Currently it would return a false answer for adult mobs.

Gargaj · 2015-11-29T21:18:40Z

It's a bit of a mess because "age" seems to have two uses: http://minecraft.gamepedia.com/Chunk_format/Breedable

SafwatHalaby · 2015-11-29T21:27:19Z

src/Mobs/PassiveMonster.cpp

+		GetFollowedItems(FollowedItems);
+		if (FollowedItems.Size() > 0)
+		{
+			cPlayer * a_Closest_Player = m_World->FindClosestPlayer(GetPosition(), static_cast<float>(m_SightDistance));


This code means that the player holding the bait must be the nearest player, is this the case in Vanilla? This is a minor issue though, and can be resolved after this merge.

That's not my code, I just worked around it.

What about a DoWithClosestPlayers(Position, Callback)?
It would sort the players based on how far they are away from the position. The closest player first, and the furthest as last. When the callback returns true it stops.

Shouldn't there be an equiavilant with a max-distance cap? You don't want to sort all the players in the world every tick for every mob.

This code is just ripe for a rewrite. We don't want to be finding the closes player all the time, instead, we should store the followed player and only update it from time to time. The variable name is super-confusing, too, since we use a_ prefix for function args. And of course we want to react to non-closest players, too, if applicable.

SafwatHalaby · 2015-11-29T21:42:43Z

Does the love cooldown reset on a failed attempt? The only call to ResetLoveMode is when breeding succeeds. Shouldn't it be called also when m_LoveTimer~~m_LoveCooldown~~ reaches zero?
I am pretty ignorant with regards to the chunk saving aspect of Cuberite. Are the timers saved properly on chunk loads / unloads? @worktycho @madmaxoft @tigerw

Gargaj · 2015-11-29T21:50:48Z

From what I can tell trying it in vanilla, no, you can re-feed the animals once the initial burst of love expires.
I didn't update the NBT writer yet.

rom1504 · 2015-11-29T21:51:03Z

You need to send the entity status "love mode" every n ms (got to figure out n) to near players if you want them to see the hearts for 30s. Only the client of the player that give the wheat predicts the "love mode" itself. Not sure if you already do that ? (trying these stuff with 2 clients is generally useful to make sure it's not just the client predicting stuff)

Edit: actually, I tried it with the vanilla server and it doesn't do that (the 2nd vanilla client can only see the first heart (for 1 sec))
No idea if this is a vanilla bug or the expected behavior, so currently you indeed do stuff like vanilla.

SafwatHalaby · 2015-11-29T21:56:01Z

@Gargaj You are correct about point 1.

SafwatHalaby · 2015-11-29T21:58:28Z

Shouldn't the partner be nullified when m_LoveTimer hits zero to avoid chasing the partner after the hearts go away?

Gargaj · 2015-11-29T22:00:14Z

There's no such state. If the mob has a partner, m_LoveTimer doesn't matter anymore.

SafwatHalaby · 2015-11-29T22:01:28Z

Consider a case where you isolate the two partners just after they lock in to each other. Shouldn't they give up at some point?

Gargaj · 2015-11-29T22:02:35Z

Right now it doesn't actually matter that they can't reach each other. :)
I don't know how vanilla deals with that, if at all.

SafwatHalaby · 2015-11-29T22:05:59Z

I just tested this, two chickens had bred through a 2-block thick wall. Once they lock in, their physical position doesn't matter any more, a baby will be born. I never knew that.

SafwatHalaby · 2015-11-29T22:06:12Z

-Tested with Vanilla-

Gargaj · 2015-11-29T22:22:01Z

There are so many jokes to be made about that.

SafwatHalaby · 2015-11-29T22:28:44Z

Lol.
The code looks great to me. Thanks for this PR.
Is it ok for me to merge?

Implement aging + breeding

SafwatHalaby · 2015-11-30T08:39:25Z

Vanilla does care about mob reaching each other. Apparently ~2 blocks is the maximum distance in which the mobs can still breed. Seperating them with a 3-block wall prevents breeding and makes them give up after a while.

madmaxoft · 2015-11-30T08:50:46Z

src/Mobs/PassiveMonster.h

+	cPassiveMonster * m_LovePartner;
+	int m_LoveTimer;
+	int m_LoveCooldown;
+	int m_MatingTimer;


These should have been documented - what they do, how they interact with each other etc.

Gargaj · 2015-12-01T16:47:40Z

Question: If you said above 2 blocks distance they dont breed, do they go into post-breed cooldown or can you re-feed them?

SafwatHalaby · 2015-12-06T05:52:53Z

I will test that as soon as I can. But I think this is the least urgent of the AI issues.

Gargaj · 2015-12-06T11:30:43Z

Sure, but also reasonably easy to fix :)

jammet · 2015-12-07T12:38:32Z

I think they should be in love mode for a few more seconds, -- right now it's rather short, but I'm so glad this is being tackled!

Maybe it was just by chance but I noticed that sheep do not inherit their fur/wool color yet, and that we don't get domesticated cats when ocelots breed.

Thanks for all of this!! :)

Outfenneced · 2015-12-11T18:53:48Z

Looks like there's currently no way to pass down information from parents. Might even just be a good idea to pass the parents to the baby's constructor and have each baby mob do their own thing with the information. For instance, a baby sheep will find the wool color of the parents and use that to determine their wool color.

jammet · 2015-12-12T11:45:43Z

On a technical side, I don't know how this works at all. But I'm glad you're figuring it out. Thank you very much :).

Gargaj · 2015-12-12T12:16:22Z

The only reason I haven't added the wool color cos I haven't figured out how the colors blend when they're different color. Otherwise it's just some additional conditions right after the baby spawn.

implement breeding

4ae3b64

rom1504 mentioned this pull request Nov 29, 2015

Mating PrismarineJS/flying-squid#138

Open

SafwatHalaby reviewed Nov 29, 2015
View reviewed changes

SafwatHalaby added a commit that referenced this pull request Nov 30, 2015

Merge pull request #2696 from Gargaj/breeding

1a9c023

Implement aging + breeding

SafwatHalaby merged commit 1a9c023 into cuberite:master Nov 30, 2015

This was referenced Nov 30, 2015

Cows do not breed #2300

Closed

Implement mob breeding. #1258

Closed

Update NBT writer for breeding #2698

Open

madmaxoft reviewed Nov 30, 2015
View reviewed changes

Gargaj deleted the breeding branch November 30, 2015 12:07

Gargaj mentioned this pull request Dec 12, 2015

Sheep color inheritance #2738

Merged

SafwatHalaby mentioned this pull request Jan 30, 2016

Horses do not react to being tamed properly. #2924

Closed

Seadragon91 mentioned this pull request Mar 19, 2017

Animal breeding doesn't work #1785

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement aging + breeding #2696

Implement aging + breeding #2696

Gargaj commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby Nov 29, 2015

Gargaj Nov 29, 2015

NiLSPACE Nov 30, 2015

SafwatHalaby Nov 30, 2015

madmaxoft Nov 30, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

rom1504 commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 30, 2015

madmaxoft Nov 30, 2015

SafwatHalaby Nov 30, 2015

Gargaj commented Dec 1, 2015

SafwatHalaby commented Dec 6, 2015

Gargaj commented Dec 6, 2015

jammet commented Dec 7, 2015

Outfenneced commented Dec 11, 2015

jammet commented Dec 12, 2015

Gargaj commented Dec 12, 2015

Implement aging + breeding #2696

Implement aging + breeding #2696

Conversation

Gargaj commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby Nov 29, 2015

Choose a reason for hiding this comment

Gargaj Nov 29, 2015

Choose a reason for hiding this comment

NiLSPACE Nov 30, 2015

Choose a reason for hiding this comment

SafwatHalaby Nov 30, 2015

Choose a reason for hiding this comment

madmaxoft Nov 30, 2015

Choose a reason for hiding this comment

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

rom1504 commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

Gargaj commented Nov 29, 2015

SafwatHalaby commented Nov 29, 2015

SafwatHalaby commented Nov 30, 2015

madmaxoft Nov 30, 2015

Choose a reason for hiding this comment

SafwatHalaby Nov 30, 2015

Choose a reason for hiding this comment

Gargaj commented Dec 1, 2015

SafwatHalaby commented Dec 6, 2015

Gargaj commented Dec 6, 2015

jammet commented Dec 7, 2015

Outfenneced commented Dec 11, 2015

jammet commented Dec 12, 2015

Gargaj commented Dec 12, 2015