Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the deadlock detector interval to 120 seconds.Closes #2550 #2765

Closed
wants to merge 1 commit into from

Conversation

Seadragon91
Copy link
Contributor

Changed the default deadlock detector interval to 120 seconds.

@Seadragon91 Seadragon91 changed the title Changed to 120 seconds. Closes #2550 Changed the deadlock detector interval to 120 seconds.Closes #2550 Dec 17, 2015
@Seadragon91
Copy link
Contributor Author

If 120 seconds are okay, please merge.

@madmaxoft
Copy link
Member

I'm not too happy about this change, 120 seconds per tick is really bad, but what can I do.

@SafwatHalaby
Copy link
Member

What kind of computations take that long in the first place?

@Seadragon91
Copy link
Contributor Author

Currently is the problem, that the nether world will be generated if you go into the portal. On a raspberry pi, it takes longer than the 20 seconds, then the deadlock detector assumes freeze and aborts the server.

@madmaxoft
Copy link
Member

So we're fixing the result, instead of the cause...

@Seadragon91
Copy link
Contributor Author

Another problem is if you fly trough the world, where it also can deadlock, issue #2263. Chunk generator to overloaded.

@Seadragon91
Copy link
Contributor Author

I know this is only a workaround...

@SafwatHalaby
Copy link
Member

Some proposals:

  • Solve traveling through portals issue via "Phantom worlds" #2810.
  • When the chunk generator is overloaded (due to flight / fast movement), prevent players from venturing further into ungenerated areas by creating a temporary invisible wall.

This should eliminate the need for this PR and fix the actual issues rather than the symptoms.

@Seadragon91 Seadragon91 closed this Feb 1, 2016
@Seadragon91 Seadragon91 deleted the deadlock_interval branch February 1, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants