Added detailed logging to cBlockArea::Read() bad Y coords. #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we should hide these warnings in Release mode? Or we should add a debug mode for plugins where these warnings are shown. Not per-plugin, because that would be too difficult, but as a setting in the server. |
|
If we hid them, we'd never really get the reports and never would fix such issues. I prefer people complaining to having hidden bugs. |
|
True, but if the problem is in a badly written plugin rather than the server it could get pretty annoying. |
|
A badly written plugin can always be fixed |
madmaxoft
force-pushed
the
DetailedBlockAreaLogging
branch
from
4e69ebb
to
e4adf2f
Compare
madmaxoft
added a commit
that referenced
this pull request
Jan 12, 2016
Added detailed logging to cBlockArea::Read() bad Y coords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: http://forum.mc-server.org/showthread.php?tid=2307