-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terrain gen docs #3078
Add terrain gen docs #3078
Conversation
Travis failes... Looks like you got serious errors in the code... (did you test it locally?) |
No, I was on a train so couldn't access any Linux box for compilation. Fixing now. |
b355e95
to
4555337
Compare
All green now :) |
4555337
to
7bf6d3f
Compare
If this is the same changes as I previously reviewed, then they are good. What did you think about some basic CSS for that page to make it easier to read, similar to https://book.cuberite.org? |
I have adjusted the text based on some of your notes, so it is an updated version - has a lot more pictures and examples, not to mention the basic TOC :) Honestly, I don't like the CSS too much. Anything that constrains the contents' width to anything less than the full screen worth is, in my opinion, worthless - why have a big screen if a stupid webpage won't fit it anyway? Still, the CSS could be changed independently of this PR - this is more about the content, while CSS is more about presentation. |
There are surveys (and I agree personally) that text is better readable if you don't have wide lines. Have you ever seen a newspaper without columns? |
The changes you made are good, only thing I might do is switch the River and MixRivers pictures over, as the output from "River" is the input to "MixRivers"? Other than that, looks good to me. |
@Schwertspize If I want columns, I'll make my web browser window narrower. If I don't want columns, I want the web to allow me not to have columns. @bearbin the operations are listed alphabetically. |
@madmaxoft could you please rebase your changes, so we can merge this? |
7bf6d3f
to
4947b4d
Compare
Rebased |
4947b4d
to
a53371b
Compare
Added a new section about the
Grown
biome generator, plus a program to generate the example images.Documentation preview is available at http://cuberite.xoft.cz/docs/Generator.html