Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terrain gen docs #3078

Merged
merged 2 commits into from
May 29, 2016
Merged

Add terrain gen docs #3078

merged 2 commits into from
May 29, 2016

Conversation

madmaxoft
Copy link
Member

Added a new section about the Grown biome generator, plus a program to generate the example images.

Documentation preview is available at http://cuberite.xoft.cz/docs/Generator.html

@ghost
Copy link

ghost commented Mar 12, 2016

Travis failes... Looks like you got serious errors in the code... (did you test it locally?)

@madmaxoft
Copy link
Member Author

No, I was on a train so couldn't access any Linux box for compilation. Fixing now.

@madmaxoft
Copy link
Member Author

All green now :)

@bearbin
Copy link
Member

bearbin commented Mar 12, 2016

If this is the same changes as I previously reviewed, then they are good.

What did you think about some basic CSS for that page to make it easier to read, similar to https://book.cuberite.org?

@madmaxoft
Copy link
Member Author

I have adjusted the text based on some of your notes, so it is an updated version - has a lot more pictures and examples, not to mention the basic TOC :)

Honestly, I don't like the CSS too much. Anything that constrains the contents' width to anything less than the full screen worth is, in my opinion, worthless - why have a big screen if a stupid webpage won't fit it anyway?

Still, the CSS could be changed independently of this PR - this is more about the content, while CSS is more about presentation.

@ghost
Copy link

ghost commented Mar 12, 2016

why have a big screen if a stupid webpage won't fit it anyway?

There are surveys (and I agree personally) that text is better readable if you don't have wide lines. Have you ever seen a newspaper without columns?

@bearbin
Copy link
Member

bearbin commented Mar 12, 2016

The changes you made are good, only thing I might do is switch the River and MixRivers pictures over, as the output from "River" is the input to "MixRivers"? Other than that, looks good to me.

@madmaxoft
Copy link
Member Author

@Schwertspize If I want columns, I'll make my web browser window narrower. If I don't want columns, I want the web to allow me not to have columns.

@bearbin the operations are listed alphabetically.

@sphinxc0re
Copy link
Contributor

@madmaxoft could you please rebase your changes, so we can merge this?

@madmaxoft
Copy link
Member Author

Rebased

@madmaxoft madmaxoft merged commit bbcf2d6 into master May 29, 2016
@tigerw tigerw deleted the AddTerrainGenDocs branch June 5, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants