Auto clean bad world linkages #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the server refuses to start when a
world.inihas nonexisting worlds. This is confusing for people, and we published a full guide. After this PR, the server will simply remove bad linkages on startup (A message will appear in the console, telling the player that the server has done this).Justifying scenario: If an admin removes world_nether from settings.ini in an attempt to disable the nether, the server refuses to start without this PR. The admin expects it to start as usual, without the nether. After this PR, the server will "garbage collect" world_nether and remove it from every linkage it was referenced from.
In short, if a world has
LinkedWorldName=my_Deleted_worldand thenmy_deleted_worldis removed fromsettings.ini, the server setsLinkedWorldNameto blank.