-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the 1.11 protocol #3480
Conversation
@NiLSPACE , @sphinxc0re , @Pokechu22 what do you think of the new class names, are they alright? |
I like the idea of naming them that way (especially for the file names), but I feel like it might be clearer to name the first versions |
I totally agree with @Pokechu22 here. The classnames are much better to read and better to distinguish |
Yeah, the names are much better. |
2e72445
to
66a805c
Compare
I'm not too enthusiastic about |
Having no suffix could also indicate that the class is used for all 1.9 protocols, so I'm inclined to keep it with the suffix. |
The problem with that is that you don't know whether there will be a new version, until they make the next "major" update, at which point you'll be renaming the class just for the sake of the suffix. |
Okay, two against one, I'll rename the classes to include the suffix, and then I'm done with this PR :) |
Great :) |
66a805c
to
c7ce990
Compare
Now the websites needs to be updated. |
@mathiascode to the rescue. Also update the banner |
I wouldn't advertise 1.11 support just yet. It's very preliminary, I have a feeling that even when a second player joins the game, both players' clients will crash. I'd wait until #3479 is closed. |
Once entities work fine again, I will update the website. |
It seems the OnPlayerRightClick hook is called twice in 1.11. Is that a bug in our code or did the protocol actually change to do that? |
Basic support for the 1.11 protocol. Doesn't support mobs yet (any mob will D/C clients immediately)
Also changed the protocol classes' names for better legibility, and slightly refactored to allow simple overrides for handling incoming packets.
Ref.: #3479