Grow in handlers #4419
Grow in handlers #4419
Conversation
madmaxoft
force-pushed
the
GrowInHandlers
branch
from
50b91cf
to
2d6fa22
Compare
madmaxoft
force-pushed
the
GrowInHandlers
branch
from
9c6f5b1
to
719ae3f
Compare
| a_Chunk.UnboundedRelFastSetBlock(pos, E_BLOCK_CACTUS, 0); | ||
|
|
||
| // Check surroundings. Cacti may ONLY be surrounded by non-solid blocks; if they aren't, drop as pickup and bail out the growing | ||
| static const Vector3i neighborOffsets[] = |
There was a problem hiding this comment.
The cactus popping off seems perfect for a OnUpdate. Does the current code still work when I place a block next to the cactus?
There was a problem hiding this comment.
Should still work, thanks to CanBeAt (can't try right now). But it's true that the checking code should be reused, rather than having a copy here. Will fix.
There was a problem hiding this comment.
Can't fix easily, CanBeAt takes too different a set of parameters; changing CanBeAt to accept a single cChunk and Vector3i makes too many unrelated changes in other handlers, I'd prefer not to go that deep within this PR - especially when the block handlers will most likely be dropped entirely for the 1.13 change and then re-written from scratch.
Moved block growing from
cWorld/cChunkinto the specificcBlockHandlerdescendants andcItemHandlerDyefor bonemeal-related actions.Note that this PR includes the changes from #4417, I will rebase this once that PR is merged.(rebased)Also note that this PR removes the possibility to configure per-block bonemeal-ability. It is expected to return after 1.13 changes.
Fixes #4407.