Armor Stand rebase and improvements #5307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Send attached state to new player * Define armor stand basis * Complete armor model, need tweaks to be used in game * Handle armor stand and left hand of armor slots * Handle armor stand storage * Add support for invisibility Co-authored-by: Ethan Jones <ethan@yasfu.net>
* add HOOK_PLAYER_CLICKING_AT_ENTITY interaction * Prepare left hand integration * Handle interaction ClickedAt * Replace armor stand property size by isMarker and isSmall * Enable gravity for armor stand and allow nogravity * Polishing docs * Remove TODOs and apply Morgan rule * Patch HasGravity according to Float encoding * Save ArmorStand in vanilla way * Switch rotation from Vector3d to Vector3f and make save working properly according to armor stand data * Show left hand content to other players * Send armor rotations if invisible, but not if it's a marker * Hit -> Click * IsSmall -> IsSizeSmall * South -> Z+ Co-authored-by: Ethan Jones <ethan@yasfu.net>
LittleBigBug
force-pushed
the
armor-stand-pk
branch
6 times, most recently
from
c23fc34
to
acce86b
Compare
LittleBigBug
force-pushed
the
armor-stand-pk
branch
from
acce86b
to
b4c8541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a take over of #4330 and rebases fully onto master (commits condensed) with many fixes.
Ticks a checkbox in #3499
I didn't test Lua bindings/markers.