Handle newlines in cIniFile

[MacaylaMarvelous81]

This pull request replaces \n with newline a newline when reading an ini file. When writing to an ini file, the newline will be replaced with \n.

Example 1:

# settings.ini
# ...
[Server]
Description=Line 1\nLine 2
# ...

Example 2:

--- ...
local iniFile = cIniFile()

iniFile:SetValue("Key", "ValueName", "My Line 1\nMy Line 2")
iniFile:WriteFile("test.ini")
--- ...

# test.ini
[Key]
ValueName=My Line 1\nMy Line 2

Fixes #5026

[NiLSPACE]

Isn't including regex for this overkill? Wouldn't a myString.replace("\\n", "\n") work as well?

[12xx12]

Thank you for your contribution!

Firstly, please add yourself to the CONTRIBUTORS file to acknowledge our license and that your code is used in accordance to that.

Secondly I agree with @NiLSPACE that regex is a bit overkill.

Thirdly: Maybe we should add a sentence here, that line breaks are now supported and how they work

[MacaylaMarvelous81]

Should I use ReplaceString from StringUtils instead of regex?

[12xx12]

Yes, please

[bearbin]

Indeed, regex is a bit overkill, ReplaceString is a good alternative.

Also, please make sure it's possible to write a literal \n in the config! I suggest matching on \\n and replacing with \n (and the same in reverse). If we had other special characters to escape, replacing \\ with \ might make sense but just matching \\n makes most sense here to avoid mangling data unnecessarily.

[12xx12]

With the constraint mentioned, maybe regex is the way to go. If we want to add more for whatever reason, this is the easiest way to extend.

[MacaylaMarvelous81]

Sorry for taking forever to push.. I'm having trouble with pushing to my fork

[bearbin]

This doesn't address my comment made earlier; but I'd be happy to merge without that fix.

I do want the duplicated variables sorted out, no reason to have them.

[bearbin]

Not sure what the point of having two separate strings here is - since writevalue is always set to the value of runvalue! Same for rawvalue up above.

Please remove one.

[12xx12]

I Fixed your request @bearbin