byte buffer refactor #5486
Open
byte buffer refactor #5486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more constants - more comments - using smart pointer for memory
madmaxoft
reviewed
May 7, 2023
src/ByteBuffer.cpp
Outdated
| int Shift = 0; | ||
| unsigned char b = 0; | ||
| std::size_t Shift = 0; | ||
| unsigned char ReadByte = 0; |
There was a problem hiding this comment.
I think I prefer the simple b here, since English has the unfortunate ambiguity in Read (past tense vs imperative). ReadByte sounds like doReadByte to me, rather than theByteThatWasRead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to maintain readability. I thought about using
sizeof()to define the read/write byte count, but this seems a bit overkill and may lower readability.