Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using std::array to store blocks in cChunkDef #5487

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

12xx12
Copy link
Member

@12xx12 12xx12 commented Apr 8, 2023

  • Using std::array to store Blocks
  • accompanying casts
  • replace typedef with using
  • copy constructor instead of memcpy

- Using std::array to store Blocks
- accompanying casts
- replace typedef with using
- copy constructor instead of memcpy
Style checker failed
- Replaced some more casts with an inline method
- less calls to std::copy (or derivates)
@bearbin
Copy link
Member

bearbin commented Apr 15, 2023

Another frozen build, this time on the generation process of the Cuberite startup:


100% tests passed, 0 tests failed out of 28

Total Test time (real) =  12.41 sec
Log: [596da8b9b1c01435|17:15:46] --- Started Log ---
Log: [596da8b9b1c01435|17:15:46] Cuberite CI clang Debug (id: {2})
Log: [596da8b9b1c01435|17:15:46] from commit 0074018676bfec67f0922a582125107f0212dcfa built at: Sat Apr 15 17:03:50 UTC 2023
Log: [596da8b9b1c01435|17:15:46] Creating new server instance...
Log: [596da8b9b1c01435|17:15:46] Reading server config...
Warning: [596da8b9b1c01435|17:15:46] Regenerating settings.ini, all settings will be reset
Log: [596da8b9b1c01435|17:15:46] Starting server...
Info: [596da8b9b1c01435|17:15:46] Compatible clients: 1.8.x-1.12.x
Log: [596da8b9b1c01435|17:15:46] Compatible protocol versions 47, 107, 108, 109, 110, 210, 315, 316, 335, 338, 340
Log: [596da8b9b1c01435|17:15:46] Generating protocol encryption keypair...
Warning: [596da8b9b1c01435|17:15:46] Regenerating webadmin.ini, all settings will be reset
Log: [596da8b9b1c01435|17:15:46] Initialising WebAdmin...
Warning: [596da8b9b1c01435|17:15:46] WebServer: The server will run in unsecured HTTP mode.
Info: [596da8b9b1c01435|17:15:46] Put a valid HTTPS certificate in file 'webadmin/httpscert.crt' and its corresponding private key to 'webadmin/httpskey.pem' (without any password) to enable HTTPS support
Log: [596da8b9b1c01435|17:15:46] Loading settings...
Info: [596da8b9b1c01435|17:15:46] Creating default ranks...
Info: [596da8b9b1c01435|17:15:46] Default ranks created.
Log: [596da8b9b1c01435|17:15:46] Loading crafting recipes from crafting.txt...
Log: [596da8b9b1c01435|17:15:46] Loaded 789 crafting recipes
Log: [596da8b9b1c01435|17:15:46] Loaded 1.12.2 380 recipe book
Warning: [596da8b9b1c01435|17:15:46] Cannot open file "Protocol/1.13/base.recipes.txt", no recipe book recipes will be available!
Warning: [596da8b9b1c01435|17:15:46] Cannot open file "Protocol/1.14.4/base.recipes.txt", no recipe book recipes will be available!
Log: [596da8b9b1c01435|17:15:46] Loading furnace recipes...
Log: [596da8b9b1c01435|17:15:46] Loaded 67 furnace recipes and 66 fuels
Log: [596da8b9b1c01435|17:15:46] Loading brewing recipes...
Log: [596da8b9b1c01435|17:15:46] Loaded 49 brewing recipes
Log: [596da8b9b1c01435|17:15:46] Loading worlds...
Log: [596da8b9b1c01435|17:15:46] cWorld::cWorld("world")
Warning: [596da8b9b1c01435|17:15:46] Failed to load scoreboard from "world/data/scoreboard.dat": basic_ios::clear: iostream error
Warning: [596da8b9b1c01435|17:15:46] Cannot read world settings from "world/world.ini", defaults will be used.
Log: [596da8b9b1c01435|17:15:46] Allowed mob: bat
Log: [596da8b9b1c01435|17:15:46] Allowed mob: cavespider
Log: [596da8b9b1c01435|17:15:46] Allowed mob: chicken
Log: [596da8b9b1c01435|17:15:46] Allowed mob: cow
Log: [596da8b9b1c01435|17:15:46] Allowed mob: creeper
Log: [596da8b9b1c01435|17:15:46] Allowed mob: guardian
Log: [596da8b9b1c01435|17:15:46] Allowed mob: horse
Log: [596da8b9b1c01435|17:15:46] Allowed mob: mooshroom
Log: [596da8b9b1c01435|17:15:46] Allowed mob: ocelot
Log: [596da8b9b1c01435|17:15:46] Allowed mob: pig
Log: [596da8b9b1c01435|17:15:46] Allowed mob: rabbit
Log: [596da8b9b1c01435|17:15:46] Allowed mob: sheep
Log: [596da8b9b1c01435|17:15:46] Allowed mob: silverfish
Log: [596da8b9b1c01435|17:15:46] Allowed mob: skeleton
Log: [596da8b9b1c01435|17:15:46] Allowed mob: slime
Log: [596da8b9b1c01435|17:15:46] Allowed mob: spider
Log: [596da8b9b1c01435|17:15:46] Allowed mob: squid
Log: [596da8b9b1c01435|17:15:46] Allowed mob: wolf
Log: [596da8b9b1c01435|17:15:46] Allowed mob: zombie
Info: [596da8b9b1c01435|17:15:46] Chosen a new random seed for world: 564109486
Log: [596da8b9b1c01435|17:15:46] Using a cache for biomegen of size 16.
Log: [596da8b9b1c01435|17:15:46] Enabling multicache for biomegen of length 128.
Warning: [596da8b9b1c01435|17:15:46] Invalid biome ("BambooJungle") specified in AllowedBiomes in cubeset file Prefabs/SinglePieceStructures/JungleTemple.cubeset. Skipping the biome.
Warning: [596da8b9b1c01435|17:15:46] Invalid biome ("BambooJungleHills") specified in AllowedBiomes in cubeset file Prefabs/SinglePieceStructures/JungleTemple.cubeset. Skipping the biome.
Log: [596da8b9b1c01435|17:15:46] cSending interrupt signal to process

So it somehow froze halfway through the debug log beginning with cXXX there, and then I manually killed it.

@12xx12
Copy link
Member Author

12xx12 commented Apr 15, 2023

meme

@12xx12
Copy link
Member Author

12xx12 commented Apr 16, 2023

Well... it was just a simple '&'

But now cPlayer doesn't have its world x(

@12xx12
Copy link
Member Author

12xx12 commented Apr 17, 2023

Another frozen build, this time on the generation process of the Cuberite startup:

Is there a way to set a timeout for this? Like in Appveyor?
I thought about moving the deadlock detector. But this makes little sense, since slow machines might take some time in the generation process. And if we survey this. This might result in false positives.

@bearbin
Copy link
Member

bearbin commented Apr 17, 2023 via email

@12xx12 12xx12 added this to the C++11 conversion milestone Sep 27, 2023
@12xx12
Copy link
Member Author

12xx12 commented Oct 2, 2023

Aaaaahhhh - why does it crash in the build server. I tried multiple compilers and all work on my machine (tm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants