Integrate GoogleTest and refactor ByteBuffer and BoundingBox tests #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit integrates GoogleTest into the project, replacing the existing test framework. It refactors the tests for the ByteBuffer and BoundingBox classes to use GoogleTest format. Tests were updated with GoogleTest's assertions and boxing. In addition, the code introduces a new method to download GoogleTest as a CMake external project. New tests have been added covering all essential areas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to come back to cuberite and to start out apply stuff from the software architecture lecture xD
I want to add more and better tests.
I chose google test as a framework. If we want another, we can swap.
I know we have the other already in place, but the Google test has more assertions and support for mocking