Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

}bedrock.cube.data.export - Issue with decimal separator #212

Closed
macmaj opened this issue Oct 19, 2020 · 6 comments
Closed

}bedrock.cube.data.export - Issue with decimal separator #212

macmaj opened this issue Oct 19, 2020 · 6 comments
Labels
bug question
Milestone
4.1.3

Comments

@macmaj
Copy link
Contributor

macmaj commented Oct 19, 2020

Describe what you did so far.
I have recently updated a snapshot process at a clients from v3 to v4.
This process used bedrock export and bedrock import to transfer data between active and snapshot version.

This has caused problems for users whos language settings in browser (they execute TI from PAW) set decimal separator as comma instead of dot.

Problem is caused by the fact that now bedrock export 'respects' those language settings and exports values with comma as decimal separator, but then incorrectly loads them because bedrock import expects dot as decimal separator.

This is caused by below lines in export:

image

This part was missing from v3 and I wonder if that was done on purpose to retain users value formatting.

PS I thought that this can be manipulated with pCharacterSet but SetOutputCharacterSet doesn't have any impact on decimal separator.

PS2 I already have an alternative ways to achieve same results correctly so this question is not to get my issue at a clients resolved.

PS3 I did not test but I expect that I could experience same issues while using bedrock copy with pFile = 1

Describe what's not working the way you expect.

[Described above]

Version

  • OS: Windows Server 2016
  • TM1 Server Version: tested on 11.8.00000.33 and 11.6.00000.14

Additional context

N/A
@lotsaram lotsaram mentioned this issue Dec 16, 2020
Closed
@lotsaram
Copy link
Collaborator

duplicated in #232

@lotsaram lotsaram added this to the 4.1.3 milestone Dec 17, 2020
@HighKeys
Copy link

Hello,

is there a hotfix available? Or an est Release with a fix for this Bug?

Thank you!

@lotsaram
Copy link
Collaborator

Hi @OliverS-Dev
No this is not addressed as yet. But if you would like to do a fix and submit a pull request then you are most welcome.

@MateuszOszer
Copy link
Contributor

Fixed in main branch

@lotsaram lotsaram mentioned this issue Feb 24, 2021
Closed
@lotsaram
Copy link
Collaborator

@MateuszOszer can you please double-check and coordinate with @macmaj ?
From my reading of the ticket the fix is not required in the data.export process but the data.import processas this only accepty values using "." as the decimal separator and not ",".

@lotsaram lotsaram added the bug label Feb 24, 2021
lotsaram added a commit that referenced this issue Mar 3, 2021
@MateuszOszer @lotsaram
}bedrock.cube.data.export - Issue with decimal separator #212 (#244)
3250701 
* Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

* Update }bedrock.cube.data.import.pro

* }bedrock.cube.data.export - Issue with decimal separator #212

}bedrock.cube.data.export - Issue with decimal separator #212

Co-authored-by: lotsaram <swiltshire@cubewise.com>
@lotsaram
Copy link
Collaborator

lotsaram commented Mar 3, 2021

Fixed in #244
Replace Numbr function which always uses "." as decimal separator with StringToNumber which respects local number settings.

@lotsaram lotsaram closed this as completed Mar 3, 2021
lotsaram added a commit that referenced this issue Mar 3, 2021
@MateuszOszer @lotsaram
}bedrock.cube.data.copy - pCubeLogging = 0 and parallel threading res…
b8a1ff3 
…ults in no logging instead of initial logging state #235 (#245)

* Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

* Update }bedrock.cube.data.import.pro

* }bedrock.cube.data.export - Issue with decimal separator #212

}bedrock.cube.data.export - Issue with decimal separator #212

* }bedrock.cube.data.copy - pCubeLogging = 0 and parallel threading results in no logging instead of initial logging state #235

}bedrock.cube.data.copy - pCubeLogging = 0 and parallel threading results in no logging instead of initial logging state #235

Co-authored-by: lotsaram <swiltshire@cubewise.com>
lotsaram added a commit that referenced this issue Mar 3, 2021
@MateuszOszer @lotsaram
When cloning client set password (#246)
9b1da26 
* Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

Fix for }bedrock.cube.data.import - double character delimiters causes error when pMappingToNewDims used #203

* Update }bedrock.cube.data.import.pro

* }bedrock.cube.data.export - Issue with decimal separator #212

}bedrock.cube.data.export - Issue with decimal separator #212

* }bedrock.cube.data.copy - pCubeLogging = 0 and parallel threading results in no logging instead of initial logging state #235

}bedrock.cube.data.copy - pCubeLogging = 0 and parallel threading results in no logging instead of initial logging state #235

* When cloning client set password #241

When cloning client set password #241

Co-authored-by: lotsaram <swiltshire@cubewise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
4.1.3
Development

No branches or pull requests
4 participants
@HighKeys @lotsaram @macmaj @MateuszOszer