Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: fisher, mskewb, pyramorphix, helicopter, curvycopter #67

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Apr 2, 2021

I consulted with Tony Fisher on the exact Fisher cube dimensions. I purposely put it at 45° to distinguish it from the Skewb family, but I'm open to using orthogonal alignment for the main outline.

Screen Shot 2021-04-02 at 13 02 53

Screen Shot 2021-04-02 at 13 32 01

@lgarron lgarron requested review from jfly and keemy April 2, 2021 20:06
@jfly
Copy link
Member

jfly commented Apr 2, 2021

LGTM!

@keemy
Copy link
Contributor

keemy commented Apr 5, 2021

talked offline. fine to merge.

stated reservation that fisher cube seems needlessly half the size all other cube icons but we can revisit if others mention it in the future.

@lgarron
Copy link
Member Author

lgarron commented Apr 5, 2021

stated reservation that fisher cube seems needlessly half the size all other cube icons but we can revisit if others mention it in the future.

To follow up with a bit more: I'm also alright with going to orthogonal outline, but I'd like to try this to see if it works (and if we don't get too much confusion/negative feedback about it). In the small sample of folks I've spoken to, there's no clear preference so far, but Tony himself expressed a slight preference for diagonal.

Also, I'd like to fix up the sizes and spacings of the icons at some point, at which I think we could make the diagonal one slightly larger as well.

@lgarron lgarron merged commit ef43654 into main Apr 5, 2021
@lgarron lgarron deleted the add-5 branch April 5, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants