Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

addtohomescreen triggered at first visit although returningVisitor is set to true #20

Closed
sebcante opened this issue Mar 22, 2012 · 4 comments

Comments

@sebcante
Copy link

Hi,

I really liked the concept for isReturningVisitor to maximize the change of the user to add your webapp to home screen.
I having issue with isReturningVisitor settings

Scenario :
1 - Reset iOS simulator (that will clear the localStorage, sessionStorage, the lot) --> simulate first visit
2 - I ran the suggest-config example from master
3 - Got the add to home screen bubble on the first visit (should be only on the second)

config : addToHomeConfig = {
returningVisitor: true, // Show the message only to returning visitors (ie: don't show it the first time)
expire: 720 // Show the message only once every 12 hours
};

is that a known issue ?

@cubiq
Copy link
Owner

cubiq commented Mar 22, 2012

thanks for your report. I've found the bug, I'll fix it asap

cubiq pushed a commit that referenced this issue Mar 22, 2012
@cubiq
Copy link
Owner

cubiq commented Mar 22, 2012

could you confirm the latest commit fixed this issue?

@cubiq cubiq closed this as completed Mar 22, 2012
@sebcante
Copy link
Author

i am on it this morning will let you know asap
-seb


De: Matteo Spinelli reply@reply.github.com
: sebcante seb_guard-github@yahoo.fr
Envoy le : Vendredi 23 mars 2012 4h10
Objet: Re: [add-to-homescreen] addtohomescreen triggered at first visit although returningVisitor is set to true (#20)

could you confirm the latest commit fixed this issue?


Reply to this email directly or view it on GitHub:
#20 (comment)

@sebcante
Copy link
Author

that is a tick for me, thanks for your reactivity!

-seb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants