Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve any existing JRUBY_OPTS or JAVA_OPTS #125

Closed
wants to merge 1 commit into from

Conversation

alindeman
Copy link

  • In JRuby 1.6.x, 1.9 mode is enabled by passing JRUBY_OPTS="--1.9"; it
    is desirable for these sorts of options to be passed to child ruby
    processes that aruba spawns.

* In JRuby 1.6.x, 1.9 mode is enabled by passing JRUBY_OPTS="--1.9"; it
  is desirable for these sorts of options to be passed to child ruby
  processes that aruba spawns.
@mattwynne
Copy link
Member

@alindeman can you look at why the build is broken please?

@alindeman
Copy link
Author

I believe the failures are already on master.

I think it's related to childprocess raises ChildProcess::LaunchError if the process fails to launch since 0.2.4. enkessler/childprocess#18 for more details.

What should aruba do in these cases?

@mattwynne
Copy link
Member

Fixed by #102

@mattwynne mattwynne closed this Oct 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants