Rename *_dir to *_directory #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. |
|
How about backward compatibility? Could you make some deprecated message? |
|
Already done in this PR: ;-) Please see |
|
Aaaaannd rebased... 🚀 |
|
Ok. Found some more places to fix... Done. |
jarl-dk
added a commit
that referenced
this pull request
Apr 8, 2015
…file Rename *_dir to *_directory. Thanks a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every method which works on a file is named
*_file. Every method which works on a directory is named*_dir. While file is fully written, directory is abbreviated. This PR changes this. Now all methods are fully written.