PHP: Check lowest versions of dependencies in CI #2035
Conversation
ciaranmcnulty
force-pushed
the
add-php-lowest-jobs
branch
from
fb496cd
to
efb2e61
Compare
ciaranmcnulty
force-pushed
the
add-php-lowest-jobs
branch
3 times, most recently
from
4652afe
to
44ea4d5
Compare
|
Do you confirm that as long as #2034 is not merged, the job |
|
ok I need help with make :/ I have this in the Makefile: the new jobs are running: |
|
(I copy/paste my answer on slack) It looks like using variables in a makefile is not the same as with bash refs. https://www.gnu.org/software/make/manual/html_node/Using-Variables.html So, two possibilities: using or using |
|
Actually you should be able the braces too ( |
|
Nice work @aurelien-reeves |
Yes. I suggest we merge that one (it looks fine to me) and then rebase this PR. It's good that we have 'seen it fail' |
|
Grargh Ok this doesn't work because we point to the 'local' messages with some config in composer.json, so It's probably still worth merging for the other minor fixes but I'll try and see a clean way to remove the config (in just that job) |
|
ok it's 'successfully' failing now |
This is mostly because of #2034 - we need to check that everything still works with the 'lowest' versions of the dependencies There aren't any external dependencies yet so currently this will only detect when Gherkin doesn't work with Messages any more, or when we've written tests that don't work with older versions of the test tools
The following fix is needed: ramsey/uuid#383
This is used in static analysis and older versions can't deal with enums directly Becuase we don't depend on it directly Psalm was allowing an older version to install
This is something we still want to check for even if the types say it's redundant - JSON decoding could be throwing an error here
ciaranmcnulty
force-pushed
the
add-php-lowest-jobs
branch
from
11b6947
to
9738d29
Compare
|
I guess this should now pass!? Once everything is ready, let me know for a last review :) |
|
Yes I think it can merge if passed (it failed on gherkin-php-bc just before rebase) |
| @@ -466,6 +479,21 @@ jobs: | |||
| name: gherkin/php | |||
| command: | | |||
| cd gherkin/php | |||
| composer config --unset repo.0 | |||
There was a problem hiding this comment.
Could you add some comments here to explain why we need to do this?
This is mostly because of #2034 - we need to check that everything still works with the 'lowest' versions of the dependencies that are allowed by composer.json
There aren't any external dependencies yet so currently this will only detect when Gherkin doesn't work with older versions of Messages any more, or when we've written tests that don't work with older versions of the test tools
This is expected to fail until #2034 is merged