Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove native JavaScript Gherkin parser - delegate to Go executable #448

Merged
merged 4 commits into from
Aug 4, 2018
Merged

Remove native JavaScript Gherkin parser - delegate to Go executable #448

merged 4 commits into from
Aug 4, 2018

Conversation

aslakhellesoy
Copy link
Contributor

Summary

Remove the native JavaScript parser

Details

Delegate to gherkin-go instead. TODO:

  • Make sure gherkin-go is included in npm bundle
  • Create a PR for cucumber-js to make sure this works once integrated

Motivation and Context

Less code to maintain.

How Has This Been Tested?

All approval tests pass, and a few unit tests

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aslakhellesoy aslakhellesoy merged commit 8b85909 into master Aug 4, 2018
@aslakhellesoy aslakhellesoy deleted the gherkin-javascript-remove-native-parser branch August 4, 2018 20:05
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlierudolph charlierudolph Awaiting requested review from charlierudolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aslakhellesoy