Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Nepali translation🇳🇵 #729

Merged
merged 2 commits into from
Oct 8, 2019
Merged

i18n: Nepali translation🇳🇵 #729

merged 2 commits into from
Oct 8, 2019

Conversation

ankitpokhrel
Copy link
Member

Summary

This PR adds Nepali translation to gherkin parser.

@luke-hill luke-hill merged commit 800dbff into cucumber:master Oct 8, 2019
@aslakhellesoy
Copy link
Contributor

Hi @ankitpokhrel,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@aslakhellesoy
Copy link
Contributor

Thanks for merging this @luke-hill

Please always make sure the PR's build is green before merging. This one was red when you merged it. The reason it was red is that the gherkin/gherkin-languages.json file has not been synched into the language subfolders (gherkin/*/gherkin-languages.json).

This is done with source scripts/functions.sh && rsync_files and then committing.

I will improve the build error message to make it more obvious that this is what needs to be done.

@aslakhellesoy
Copy link
Contributor

Also, please always update the CHANGELOG when you merge a PR. Not only do users use it to know what was changed in a release, we contributors use it to decide whether to bump the patch, minor or major version when we make a new release.

aslakhellesoy added a commit that referenced this pull request Oct 8, 2019
@luke-hill
Copy link
Contributor

Yeh, that build job I've never seen pass. It always fails for some permissions issue. It's been that way for me for months.

aslakhellesoy added a commit that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants