Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breaking changes in API of boost-1.66.0 #180

Closed

Conversation

matlo607
Copy link
Contributor

Motivation and Context

fix issue #178

basic_socket_adaptor has now only one template argument.

[boost-1.66.0] basic_socket_acceptor

template<typename Protocol>
class basic_socket_acceptor :
  public socket_base

[boost-1.65.0] basic_socket_acceptor

template<
    typename Protocol,
    typename SocketAcceptorService = socket_acceptor_service<Protocol>>
class basic_socket_acceptor :
  public basic_io_object< SocketAcceptorService >,
  public socket_base

How Has This Been Tested?

I built the project with boost-1.66.0 and passed the unit tests.
My environment:

Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.3 LTS
Release:	16.04
Codename:	xenial

gcc (Ubuntu 5.4.1-2ubuntu1~16.04) 5.4.1 20160904
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@matlo607 matlo607 force-pushed the fix-boost-1.66.0-breaking-changes branch from 22e765c to 1b5ed23 Compare February 13, 2018 13:14
@matlo607 matlo607 mentioned this pull request Feb 14, 2018
9 tasks
@matlo607
Copy link
Contributor Author

matlo607 commented Feb 14, 2018

@paoloambrosio, @muggenhor or @konserw : could you please review the pull request ?
Please ignore the commit 1b5ed23, konserw told me it's wrong. I will wait for #184.

@helmesjo
Copy link

helmesjo commented Mar 4, 2018

Any progress on this @matlo607 ?

@matlo607
Copy link
Contributor Author

matlo607 commented Mar 5, 2018

If you are talking about the fix for boost-1.66-0 itself, it works.
However, as I mentioned it before, I am waiting for #184 (warning considered as error and not related to this pull request).

@matlo607 matlo607 force-pushed the fix-boost-1.66.0-breaking-changes branch from 1b5ed23 to a5c1211 Compare March 21, 2018 17:26
@konserw
Copy link
Contributor

konserw commented Mar 21, 2018

Ok, I think you'll need to combine #180 #181 and -werror fix into one PR to get past all checks. It's a pitty I can't change the way it works and @paoloambrosio is not around to make changes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.329% when pulling a5c1211 on matlo607:fix-boost-1.66.0-breaking-changes into 70fa12c on cucumber:master.

@paoloambrosio
Copy link
Member

@konserw I can't seem to find any time to review these PRs so I've removed the requirement of having a reviewer for PRs

konserw added a commit to konserw/cucumber-cpp that referenced this pull request Mar 30, 2018
This is group-merge which consist actualy of following fixes:
* Remove -werror compiler flag to fix failing build with clang ([cucumber#184](cucumber#184) Kamil Strzempowicz)
* Add missing virtual destructor in base class SocketServer used by TCPSocketServer and UnixSocketServer ([cucumber#183](cucumber#183) Matthieu Longo)
* Fix breaking changes in API of boost-1.66.0 ([cucumber#180](cucumber#180)  Matthieu Longo)
* Fix conflicting "using std" declaration with "using boost::thread" ([cucumber#181](cucumber#181)  Matthieu Longo)
* Fixing Visual Studio 2013 error: no appropriate default constructor available ([cucumber#188](cucumber#188) Antoine Allard)
@konserw
Copy link
Contributor

konserw commented Mar 30, 2018

Merged as part of #189

@konserw konserw closed this Mar 30, 2018
@muggenhor muggenhor added this to the v0.5 milestone May 23, 2018
@matlo607 matlo607 deleted the fix-boost-1.66.0-breaking-changes branch July 16, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants