Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #189

Merged
merged 7 commits into from
Mar 30, 2018
Merged

Fix build #189

merged 7 commits into from
Mar 30, 2018

Conversation

konserw
Copy link
Contributor

@konserw konserw commented Mar 23, 2018

Summary

This PR pulls together commits that are meant to fix building.

Details

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@coveralls
Copy link

coveralls commented Mar 23, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 63.307% when pulling 5bc0d24 on konserw:fix-build into 70fa12c on cucumber:master.

konserw added a commit to konserw/cucumber-cpp that referenced this pull request Mar 30, 2018
@konserw
Merge cucumber#189 'Fix build'
dd83907 
This is group-merge which consist actualy of following fixes:
* Remove -werror compiler flag to fix failing build with clang ([cucumber#184](cucumber#184) Kamil Strzempowicz)
* Add missing virtual destructor in base class SocketServer used by TCPSocketServer and UnixSocketServer ([cucumber#183](cucumber#183) Matthieu Longo)
* Fix breaking changes in API of boost-1.66.0 ([cucumber#180](cucumber#180)  Matthieu Longo)
* Fix conflicting "using std" declaration with "using boost::thread" ([cucumber#181](cucumber#181)  Matthieu Longo)
* Fixing Visual Studio 2013 error: no appropriate default constructor available ([cucumber#188](cucumber#188) Antoine Allard)
@konserw konserw merged commit 5bc0d24 into cucumber:master Mar 30, 2018
konserw added a commit that referenced this pull request Mar 30, 2018
@konserw
Merge #189 'Fix build'
46fe070
This was referenced Mar 30, 2018
Closed
Closed
Closed
Closed
Closed
@konserw konserw deleted the fix-build branch April 2, 2018 10:07
@fxcoudert
Copy link

Would you consider a new release, containing this fix and other most recent commits? Thanks

@muggenhor muggenhor added this to the v0.5 milestone May 23, 2018
@helmesjo
Copy link

helmesjo commented Jul 2, 2018

Hows it looing with this @muggenhor ? Is a new release a possibility any time soon?

@muggenhor
Copy link
Contributor

@helmesjo https://github.com/cucumber/cucumber-cpp/releases/tag/v0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@konserw @coveralls @fxcoudert @helmesjo @muggenhor @aallrd @matlo607