Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-config-prettier to v8 #30

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 22, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-prettier ^7.1.0 -> ^8.0.0 age adoption passing confidence

Release Notes

prettier/eslint-config-prettier

v8.8.0

Compare Source

v8.7.0

Compare Source

v8.6.0

Compare Source

  • Added: [vue/multiline-ternary]. Thanks to @​xcatliu!

v8.5.0

Compare Source

v8.4.0

Compare Source

v8.3.0

Compare Source

v8.2.0

Compare Source

  • Added: [flowtype/quotes]. Thanks to Martin Zlámal (@​mrtnzlml)!

v8.1.0

Compare Source

  • Added: [flowtype/object-type-curly-spacing].
  • Added: Dummy files for the configs removed in 8.0.0. The dummy files throw an error that try to guide you how to upgrade.

v8.0.0

Compare Source

  • Changed: All configs have been merged into one!

    To upgrade, change:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier",
        "prettier/@​typescript-eslint",
        "prettier/babel",
        "prettier/flowtype",
        "prettier/react",
        "prettier/standard",
        "prettier/unicorn",
        "prettier/vue"
      ]
    }

    Into:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier"
      ]
    }

    The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

    So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@​lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@​thorn0) for pointing this out!

    If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:

    {
      "extends": [
        "some-other-config-you-use",
        "plugin:prettier/recommended"
      ]
    }

    (The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main "prettier" config does not include the rules from it.)

  • Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).

v7.2.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch 6 times, most recently from dafc0f6 to 6c5fb1e Compare December 28, 2022 07:56
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 6c5fb1e to d2b93f0 Compare May 28, 2023 12:37
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from d2b93f0 to 15318c9 Compare July 11, 2023 11:58
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 15318c9 to 6b7cded Compare July 11, 2023 12:13
@olleolleolle
Copy link
Contributor

olleolleolle commented Jul 11, 2023

Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

ESLint: 8.30.0

Error: Cannot read config file: /home/runner/work/cucumber-js-pretty-formatter/cucumber-js-pretty-formatter/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /home/runner/work/cucumber-js-pretty-formatter/cucumber-js-pretty-formatter/.eslintrc.js
at Object. (/home/runner/work/cucumber-js-pretty-formatter/cucumber-js-pretty-formatter/node_modules/eslint-config-prettier/@typescript-eslint.js:1:7)

@olleolleolle olleolleolle merged commit 54c6372 into main Jul 11, 2023
4 checks passed
@olleolleolle olleolleolle deleted the renovate/eslint-config-prettier-8.x branch July 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant