chore: update @cucumber/* dependencies, fix willBeRetried usage (#1776)

* latest dependencies * make it just about compile * fix test case runner * fix summary helper * fix formatters (ish) * fix last bit in formatters * update fixtures for feature tests * fix attachments cck * hook up retry cck * lint * update doc * update lockfile
cucumber · Sep 3, 2021 · 8f2ff57 · 8f2ff57
1 parent 4e85157
commit 8f2ff57
Show file tree

Hide file tree

Showing 21 changed files with 227 additions and 208 deletions.
diff --git a/compatibility/cck_spec.ts b/compatibility/cck_spec.ts
@@ -26,16 +26,20 @@ describe('Cucumber Compatibility Kit', () => {
     const suiteName = match[1]
     const extension = match[2]
     it(`passes the cck suite for '${suiteName}'`, async () => {
-      const args = [
-        'node',
-        path.join(PROJECT_PATH, 'bin', 'cucumber-js'),
-      ].concat([
+      const cliOptions = [
         `${CCK_FEATURES_PATH}/${suiteName}/${suiteName}${extension}`,
         '--require',
         `${CCK_IMPLEMENTATIONS_PATH}/${suiteName}/${suiteName}.ts`,
         '--profile',
         'cck',
-      ])
+      ]
+      if (suiteName === 'retry') {
+        cliOptions.push('--retry', '2')
+      }
+      const args = [
+        'node',
+        path.join(PROJECT_PATH, 'bin', 'cucumber-js'),
+      ].concat(cliOptions)
       const stdout = new PassThrough()
       try {
         await new Cli({

diff --git a/compatibility/features/attachments/attachments.ts b/compatibility/features/attachments/attachments.ts
@@ -63,9 +63,26 @@ When('a JPEG image is attached', async function (this: World) {
         'compatibility-kit',
         'features',
         'attachments',
-        'cucumber-growing-on-vine.jpg'
+        'cucumber.png'
       )
     ),
-    'image/jpg'
+    'image/png'
+  )
+})
+
+When('the {word} png is attached', async function (filename) {
+  await this.attach(
+    fs.createReadStream(
+      path.join(
+        process.cwd(),
+        'node_modules',
+        '@cucumber',
+        'compatibility-kit',
+        'features',
+        'attachments',
+        filename
+      )
+    ),
+    'image/png'
   )
 })
diff --git a/compatibility/features/retry/retry.ts b/compatibility/features/retry/retry.ts
@@ -0,0 +1,25 @@
+import { Given } from '../../../src'
+
+Given('a step that always passes', function () {
+  // no-op
+})
+
+let secondTimePass = 0
+Given('a step that passes the second time', function () {
+  secondTimePass++
+  if (secondTimePass < 2) {
+    throw new Error('Exception in step')
+  }
+})
+
+let thirdTimePass = 0
+Given('a step that passes the third time', function () {
+  thirdTimePass++
+  if (thirdTimePass < 3) {
+    throw new Error('Exception in step')
+  }
+})
+
+Given('a step that always fails', function () {
+  throw new Error('Exception in step')
+})
diff --git a/docs/migration.md b/docs/migration.md
@@ -61,8 +61,7 @@ Now in `@cucumber/cucumber`:
     "duration": {
       "seconds": "0",
       "nanos": 660000000
-    },
-    "willBeRetried": true
+    }
   }
 }
 ```

diff --git a/features/fixtures/formatters/failed.message.json.ts b/features/fixtures/formatters/failed.message.json.ts
@@ -139,7 +139,6 @@ module.exports = [
           nanos: 0,
         },
         status: 'FAILED',
-        willBeRetried: false,
         message: 'Error: my error',
       },
       timestamp: {
@@ -155,6 +154,7 @@ module.exports = [
         seconds: 0,
         nanos: 4000000,
       },
+      willBeRetried: false,
     },
   },
   {

diff --git a/features/fixtures/formatters/passed-rule.message.json.ts b/features/fixtures/formatters/passed-rule.message.json.ts
@@ -154,7 +154,6 @@ module.exports = [
           nanos: 0,
         },
         status: 'PASSED',
-        willBeRetried: false,
       },
       timestamp: {
         seconds: 0,
@@ -169,6 +168,7 @@ module.exports = [
         seconds: 0,
         nanos: 4000000,
       },
+      willBeRetried: false,
     },
   },
   {

diff --git a/features/fixtures/formatters/passed-scenario.message.json.ts b/features/fixtures/formatters/passed-scenario.message.json.ts
@@ -139,7 +139,6 @@ module.exports = [
           nanos: 0,
         },
         status: 'PASSED',
-        willBeRetried: false,
       },
       timestamp: {
         seconds: 0,
@@ -154,6 +153,7 @@ module.exports = [
         seconds: 0,
         nanos: 4000000,
       },
+      willBeRetried: false,
     },
   },
   {

diff --git a/features/fixtures/formatters/retried.message.json.ts b/features/fixtures/formatters/retried.message.json.ts
@@ -139,7 +139,6 @@ module.exports = [
           nanos: 0,
         },
         status: 'FAILED',
-        willBeRetried: true,
         message: 'Error: my error',
       },
       timestamp: {
@@ -155,6 +154,7 @@ module.exports = [
         seconds: 0,
         nanos: 4000000,
       },
+      willBeRetried: true,
     },
   },
   {
@@ -188,7 +188,6 @@ module.exports = [
           nanos: 0,
         },
         status: 'PASSED',
-        willBeRetried: false,
       },
       timestamp: {
         seconds: 0,
@@ -203,6 +202,7 @@ module.exports = [
         seconds: 0,
         nanos: 8000000,
       },
+      willBeRetried: false,
     },
   },
   {