Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: --retryTagFilter case inconsistent with other args #1291

Closed
davidjgoss opened this issue Feb 18, 2020 · 1 comment · Fixed by #1293
Closed

cli: --retryTagFilter case inconsistent with other args #1291

davidjgoss opened this issue Feb 18, 2020 · 1 comment · Fixed by #1293
Assignees
Labels
🐛 bug Defect / Bug
Milestone

Comments

@davidjgoss
Copy link
Contributor

To specify a tag filter for retry:

$ cucumber-js --retryTagFilter @flaky

It being in camel case is inconsistent with others like format-options, world-parameters and require-module which are kebab-case.

This is not just aesthetic, as it means if you are using something like dargs to create profile strings on the fly, you can't rely on a consistent rule.

Suggest we change it to --retry-tag-filter - we could potentially keep the camel cased one as an alias for one major release cycle and make it output a warning for now? cc @charlierudolph

@davidjgoss davidjgoss added the 🐛 bug Defect / Bug label Feb 18, 2020
@davidjgoss davidjgoss mentioned this issue Feb 18, 2020
5 tasks
@charlierudolph
Copy link
Member

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants