Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: use kebab-case for --retry-tag-filter arg #1293

Merged
merged 14 commits into from Mar 17, 2020
Merged

cli: use kebab-case for --retry-tag-filter arg #1293

merged 14 commits into from Mar 17, 2020

Conversation

davidjgoss
Copy link
Contributor

Fixes #1291

  • Issue a warning when used in camelCase (and make warnings from cli testable)
  • Update the docs

charlierudolph
charlierudolph reviewed Feb 23, 2020
View reviewed changes
src/cli/index.ts Outdated Show resolved Hide resolved
charlierudolph
charlierudolph reviewed Mar 7, 2020
View reviewed changes
src/cli/index.ts Outdated Show resolved Hide resolved
src/cli/index.ts Outdated Show resolved Hide resolved
charlierudolph
charlierudolph approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@charlierudolph charlierudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog note and then merge

@davidjgoss davidjgoss merged commit 0bbb4b9 into master Mar 17, 2020
@charlierudolph charlierudolph deleted the retry-tag-filter-case branch June 18, 2020 03:51
@davidjgoss davidjgoss mentioned this pull request Jun 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlierudolph charlierudolph charlierudolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: --retryTagFilter case inconsistent with other args
2 participants
@davidjgoss @charlierudolph