Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Loading gherkin parser according language comment #116

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant

bclozel commented Mar 27, 2013

Hello there.

This issue could be seen as a duplicate of #109 but @vslinko stopped working on this - I'm willing to give it a try.

I've been working on the same problems @vslinko faced in issue #109 : a lexing error when parsing the first non-comment line (exactly, when parsing the first keyword).
Tests and specs run ok this time - but I've stumbled on the same problems with the non-en parsers.

When debugging this issue, it seemed that valid data was passed to the non-en parser. I'm wondering if it's a parser issue or an encoding issue on our part.

Could you give me directions:

  • how could I dig deeper into this?
  • how could I create a sample testcase to check if this problem is on gherkin's/cucumber-js's side?
  • should I request support on the mailing list?

Some details about this PR:

  • works only if the "# language" meta is on the first line
  • does a "featureSource.toString", which is not optimal for nodejs implementation (since we're converting the buffer to a plain string)
  • this code should be modified in the future if we want to support other meta comments like "# encoding"

This was referenced Jan 13, 2014

Closed

@jbpros jbpros closed this in 9ace841 Mar 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment