Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1621: Json formatter fails with tagged examples #1651

Merged
merged 10 commits into from
Apr 26, 2021
Merged

Fix #1621: Json formatter fails with tagged examples #1651

merged 10 commits into from
Apr 26, 2021

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Apr 23, 2021 •
edited
Loading

Fixes #1621

  • Add tests
  • Make tests pass
  • Refactor
  • Document (update CHANGELOG)

@coveralls
Copy link

coveralls commented Apr 23, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 98.624% when pulling b2a7be7 on fix-1621-json-formatter-tagged-examples into 4f1015f on master.

@aurelien-reeves aurelien-reeves marked this pull request as ready for review April 23, 2021 13:47
davidjgoss
davidjgoss reviewed Apr 23, 2021
View reviewed changes
Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of queries, and I think we still need a changelog entry.

src/formatter/json_formatter.ts Outdated Show resolved Hide resolved
src/formatter/json_formatter.ts Outdated Show resolved Hide resolved
features/scenario_outlines.feature Outdated Show resolved Hide resolved
@aurelien-reeves
Copy link
Contributor Author

Looks good, couple of queries, and I think we still need a changelog entry.

I've pushed an update to the changelog.
The PR has not been updated yet, but the branch is https://github.com/cucumber/cucumber-js/commits/fix-1621-json-formatter-tagged-examples

@davidjgoss
Copy link
Contributor

I've pushed an update to the changelog...The PR has not been updated yet

Really confused about how/why this commit doesn't show up on the PR - is there a trick I don't know? :)

@aurelien-reeves
Copy link
Contributor Author

I've pushed an update to the changelog...The PR has not been updated yet

Really confused about how/why this commit doesn't show up on the PR - is there a trick I don't know? :)

I know it may happen when there are issue with github webhook
But did not saw any outage today on github 🤔

@aurelien-reeves
Copy link
Contributor Author

I'll update the PR with your remarks at the latest on monday

Thanks for your review :)

@aurelien-reeves
Make JsonFormatte.getScenarioTag private
9285bb4
@aurelien-reeves
Enhance scenario outlines features
131b25c 
- added a tag in the scenario which describes possibility to add tags to
  example tables
- added a scenario which describes the possibility to have several
  example tables for a single scenario
@aurelien-reeves
Refactor JsonFormatter
b2a7be7 
Inlined a small function for readibility
@aurelien-reeves aurelien-reeves merged commit 238947f into master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgoss davidjgoss davidjgoss approved these changes

@charlierudolph charlierudolph Awaiting requested review from charlierudolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cucumber JSON report fails to generate when a scenario outline has a tag
3 participants
@aurelien-reeves @coveralls @davidjgoss