Decouple process.env #1688
Closed
Decouple process.env #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
added
🔧 build
davidjgoss
reviewed
Jun 1, 2021
davidjgoss
reviewed
Jun 1, 2021
| @@ -41,6 +41,7 @@ export interface IConfiguration { | |||
| export interface INewConfigurationBuilderOptions { | |||
| argv: string[] | |||
| cwd: string | |||
| env: Record<string, string | undefined> | |||
There was a problem hiding this comment.
Could type as ProcessEnv from @types/node?
|
Nice! |
|
@aslakhellesoy is this still a live problem for you? I notice it has a lot of merge conflicts now. |
|
@mattwynne I think these changes were effectively added under #1849, looking at the state of the files now seems like the same outcome. |
|
Great, thanks for the update David. I'll close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to make tests behave independently of the value of environment variables such as
CUCUMBER_PUBLISH_TOKEN.