Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support YAML for config files #2199

Merged
merged 10 commits into from Dec 21, 2022
Merged

support YAML for config files #2199

merged 10 commits into from Dec 21, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 17, 2022

🤔 What's changed?

Add support for YAML as a configuration file format.

⚡️ What's your motivation?

We support JS and JSON; YAML is the obvious missing option.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Also as part of this, JSON configuration files are loaded with fs.readFile rather than require - this is a small non-breaking step towards moving away from require for everything.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Dec 17, 2022

Coverage Status

Coverage increased (+0.006%) to 98.335% when pulling 111e376 on feat/config-yaml into 79ba4bd on main.

@davidjgoss davidjgoss merged commit 0240308 into main Dec 21, 2022
@davidjgoss davidjgoss deleted the feat/config-yaml branch December 21, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants