Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn for ambiguous colons in formats #2335

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

Emit a warning with a link to deprecation docs when formats are specified with ambiguous colons.

⚡️ What's your motivation?

We have some smart handling for things like file:// URLs for now, but I'd rather not maintain this forever and instead have users just quote the parts of the format string (or use the array notation, in a config file), at which point we can reduce our complexity.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Feat/deprecate unquoted windows paths warn for ambiguous colons in formats Oct 6, 2023
@coveralls
Copy link

coveralls commented Oct 6, 2023

Coverage Status

coverage: 98.474% (+0.009%) from 98.465% when pulling c865f58 on feat/deprecate-unquoted-windows-paths into c1784c4 on main.

@davidjgoss davidjgoss marked this pull request as ready for review October 6, 2023 17:22
@davidjgoss davidjgoss merged commit 7110de3 into main Oct 6, 2023
10 checks passed
@davidjgoss davidjgoss deleted the feat/deprecate-unquoted-windows-paths branch October 6, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants