Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow provided configuration to be a string #2373

Merged
merged 4 commits into from Jan 15, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 15, 2024

🤔 What's changed?

Allow provided configuration in the options for loadConfiguration to be a argv-style string, as an alternative to a configuration object.

⚡️ What's your motivation?

Many existing framework integrations using the Cli class use an argv string to pass the options in, and also allow end users to express options this way. This will make it easier for such frameworks to adopt the new API, and it uses existing code that we had for handling configuration files anyway.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss force-pushed the feat/provided-configuration-string branch from 7080dfa to ea14d77 Compare January 15, 2024 11:23
@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 98.383% (+0.004%) from 98.379%
when pulling 3631869 on feat/provided-configuration-string
into 53ccc44 on main.

@davidjgoss davidjgoss force-pushed the feat/provided-configuration-string branch from ea14d77 to e679f49 Compare January 15, 2024 11:27
@davidjgoss davidjgoss marked this pull request as ready for review January 15, 2024 11:29
@davidjgoss davidjgoss merged commit 3f59e62 into main Jan 15, 2024
8 checks passed
@davidjgoss davidjgoss deleted the feat/provided-configuration-string branch January 15, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants