Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept provided configuration as array of argv #2374

Merged
merged 2 commits into from Jan 16, 2024
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 16, 2024

馃 What's changed?

Further to #2373, the argv-style provided configuration should also support being an array of strings, as you might pull directly from process.argv.

馃搵 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review January 16, 2024 10:26
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 98.385% (+0.002%) from 98.383%
when pulling 1391136 on feat/argv-accept-array
into 23e0155 on main.

@davidjgoss davidjgoss merged commit 47dbe42 into main Jan 16, 2024
8 checks passed
@davidjgoss davidjgoss deleted the feat/argv-accept-array branch January 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants