Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pretty formatter #59

Merged
merged 0 commits into from
Jun 21, 2012
Merged

Add pretty formatter #59

merged 0 commits into from
Jun 21, 2012

Conversation

renier
Copy link

@renier renier commented Apr 17, 2012

Adds a pretty printer listener/formatter, updates the help text, and adds specs for the new formatter.

@renier
Copy link
Author

renier commented Apr 24, 2012

Any comments on this?

@jbpros
Copy link
Member

jbpros commented Apr 26, 2012

@renier sorry for the late reply, thank you for the pull request. I'll take care of this soon.

@eugeneware
Copy link

When will this be merged? This is really missing from cucumber.js

@jbpros
Copy link
Member

jbpros commented Jun 11, 2012

Some tests are missing and it needs DRYing. I'm on it.

jbpros added a commit that referenced this pull request Jun 17, 2012
* Extract common listener behaviour from progress formatter
* Extract stats journal from progress formatter

Theses changes will ease the implementation of new listeners (e.g. the pretty, JSON and jUnit formatters).
jbpros added a commit that referenced this pull request Jun 19, 2012
Feature run summaries can now be reused among formatters.
@renier
Copy link
Author

renier commented Jun 20, 2012

@jbpros If you think there is anything I can do to help, let me know.

@jbpros
Copy link
Member

jbpros commented Jun 20, 2012

@renier Thanks. I'm reviewing your pull request to see how it fits with the latest refactorings. I'll try merging it but we probably need a few scenarios to test the pretty formatter.

@jbpros
Copy link
Member

jbpros commented Jun 20, 2012

As you can see in the spike, it's much easier to add a formatter. This pull request is quite different and we should probably start over by importing the bits still relevant to the current codebase.

@renier
Copy link
Author

renier commented Jun 20, 2012

@jbpros it looks like you have it already. the only thing I'm not seeing is being able to select one formatter over the other from the command line. Do you want me to do that?

I have tests in the pull request. A lot of them don't apply now that you have separated things, but the ones pertinent to the pretty formatter are among them.

@jbpros
Copy link
Member

jbpros commented Jun 20, 2012

Yep, the listener instantiation is hardcoded. This is just a spike (non-tested, cow-boy-style code) to prove everything is ready for the pretty formatter.

I'd like it to be rewritten following the normal BDD approach, with gherkin scenarios and jasmine specs. Of course, all the code you wrote previously that is still relevant can be reused.

I might get some time tonight to work on it but if you want to take back the control of this pull request, you're welcome!

I'd like to close it as soon as possible though, it's been requested by many people, for quite a long time.

jbpros added a commit that referenced this pull request Jun 20, 2012
jbpros added a commit that referenced this pull request Jun 20, 2012
@LabiKyo
Copy link

LabiKyo commented Jun 21, 2012

@joshski Thanks! I really need pretty formatter!

@jbpros
Copy link
Member

jbpros commented Jun 21, 2012

@LabiKyo np -- it's available on 0.2.17

Please note it needs improvement. There are no colours, and some things are not output yet (tags, comments, etc.).

@LabiKyo
Copy link

LabiKyo commented Jun 21, 2012

@jbpros Yes I've tried. I'd like to contribute this part, too. I'm trying some modules to print colorful output.

@jbpros
Copy link
Member

jbpros commented Jun 21, 2012

@LabiKyo neat -- feel free to submit things!

@renier renier merged commit 6e5549b into cucumber:master Jun 21, 2012
@renier
Copy link
Author

renier commented Jun 22, 2012

Creating new pull request for adding the colors.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants