fix(deps): update dependency org.testng:testng to v7.10.1 (#2875)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: M.P. Korstanje <rien.korstanje@gmail.com>
cucumber · Apr 18, 2024 · b8978f8 · b8978f8
1 parent e3a1e1c
commit b8978f8
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 55 deletions.
diff --git a/.revapi/api-changes.json b/.revapi/api-changes.json
@@ -250,105 +250,68 @@
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method void org.testng.IResultMap::addResult(org.testng.ITestResult, org.testng.ITestNGMethod)",
-            "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.method.returnTypeChanged",
-            "old": "method org.testng.IObjectFactory org.testng.ISuite::getObjectFactory()",
-            "new": "method org.testng.ITestObjectFactory org.testng.ISuite::getObjectFactory()",
-            "justification": "Third party api change"
+            "old": "method com.google.inject.Injector org.testng.IInjectorFactory::getInjector(com.google.inject.Stage, com.google.inject.Module[])",
+            "justification": "Guice is an optional TestNG dependency"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method java.lang.String org.testng.ISuiteResult::getPropertyFileName()",
+            "old": "method org.testng.IObjectFactory2 org.testng.ISuite::getObjectFactory2()",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
-            "code": "java.method.removed",
-            "old": "method void org.testng.ITestContext::addGuiceModule(com.google.inject.Module)",
+            "code": "java.field.removed",
+            "old": "field org.testng.xml.XmlSuite.DEFAULT_JUNIT",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method void org.testng.ITestContext::addInjector(java.util.List<com.google.inject.Module>, com.google.inject.Injector)",
+            "old": "method org.testng.ITestObjectFactory org.testng.xml.XmlSuite::getObjectFactory()",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method java.util.List<com.google.inject.Module> org.testng.ITestContext::getAllGuiceModules()",
+            "old": "method java.lang.Boolean org.testng.xml.XmlSuite::isJUnit()",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method java.util.List<com.google.inject.Module> org.testng.ITestContext::getGuiceModules(java.lang.Class<? extends com.google.inject.Module>)",
+            "old": "method void org.testng.xml.XmlSuite::setJUnit(java.lang.Boolean)",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method com.google.inject.Injector org.testng.ITestContext::getInjector(java.util.List<com.google.inject.Module>)",
+            "old": "method void org.testng.xml.XmlSuite::setJunit(java.lang.Boolean)",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method com.google.inject.Injector org.testng.ITestContext::getInjector(org.testng.IClass)",
-            "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.method.addedToInterface",
-            "new": "method java.lang.String org.testng.ITestResult::id()",
-            "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.method.addedToInterface",
-            "new": "method int org.testng.internal.IParameterInfo::getIndex()",
+            "old": "method void org.testng.xml.XmlSuite::setObjectFactory(org.testng.ITestObjectFactory)",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
             "code": "java.method.removed",
-            "old": "method org.testng.xml.XmlSuite.ParallelMode org.testng.xml.XmlSuite.ParallelMode::skipDeprecatedValues(org.testng.xml.XmlSuite.ParallelMode)",
+            "old": "method boolean org.testng.xml.XmlTest::isJUnit()",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
-            "code": "java.class.externalClassExposedInAPI",
-            "new": "interface org.testng.IRetryDataProvider",
-            "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.method.defaultMethodAddedToInterface",
-            "new": "method java.lang.Class<? extends org.testng.IRetryDataProvider> org.testng.IDataProviderMethod::retryUsing()",
-            "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.method.defaultMethodAddedToInterface",
-            "new": "method java.util.Set<org.testng.ITestNGMethod> org.testng.ITestNGMethod::downstreamDependencies()",
+            "code": "java.method.removed",
+            "old": "method void org.testng.xml.XmlTest::setJUnit(boolean)",
             "justification": "Third party api change"
           },
           {
             "ignore": true,
-            "code": "java.method.defaultMethodAddedToInterface",
-            "new": "method java.util.Set<org.testng.ITestNGMethod> org.testng.ITestNGMethod::upstreamDependencies()",
+            "code": "java.method.removed",
+            "old": "method void org.testng.xml.XmlTest::setJunit(boolean)",
             "justification": "Third party api change"
-          },
-          {
-            "ignore": true,
-            "code": "java.class.externalClassExposedInAPI",
-            "new": "interface io.cucumber.core.eventbus.UuidGenerator",
-            "justification": "Part of cucumber API"
           }
         ]
       }
@@ -377,7 +340,6 @@
             "new": "field com\\.google\\.inject\\.internal\\.ErrorId\\..*",
             "justification": "It's Google."
           },
-
           {
             "ignore": true,
             "code": "java.class.noLongerImplementsInterface",
@@ -409,7 +371,6 @@
             "new": "parameter com.google.inject.binder.ScopedBindingBuilder com.google.inject.binder.LinkedBindingBuilder<T>::toProvider(===com.google.inject.TypeLiteral<? extends jakarta.inject.Provider<? extends T>>===)",
             "parameterIndex": "0",
             "justification": "Guice v7 uses Jakarta"
-
           },
           {
             "ignore": true,

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 ### Changed
+- [TestNG] Update dependency org.testng:testng to v7.10.1
 - [Core] Use a [message based TestNG XML Formatter](https://github.com/cucumber/testng-xml-formatter) ([#2863](https://github.com/cucumber/cucumber-jvm/pull/2863) M.P. Korstanje)
 
 ### Added

diff --git a/cucumber-testng/pom.xml b/cucumber-testng/pom.xml
@@ -14,7 +14,7 @@
     <properties>
         <project.Automatic-Module-Name>io.cucumber.testng</project.Automatic-Module-Name>
         <hamcrest.version>2.2</hamcrest.version>
-        <testng.version>7.9.0</testng.version>
+        <testng.version>7.10.1</testng.version>
         <apiguardian-api.version>1.1.2</apiguardian-api.version>
         <mockito.version>5.11.0</mockito.version>
     </properties>