[Core ] Update jQuery from 1.8.2 to 3.4.1 #1794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated jQuery from 1.8.2 to 3.4.1 to remediate the prototype pollution in jQuery prior to 3.4.0/
Details
Updated the jQuery version and changed a call to removeAttr() to prop() to fix a deprecation warning from jQuery migrate.
Solution for jQuery.fn.removeAttr():
https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryfnremoveattr-no-longer-sets-boolean-properties
Motivation and Context
Updates jQuery to a supported version of jQuery that is safer and won't cause security scanners to flag the library as vulnerable.
How Has This Been Tested?
I've loaded it in a browser with and without jQuery migrate and remediated any issues discovered. I've also run the build + tests to ensure nothing broke.