Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support diff view for failed assertEqual condition in Intelij IDEA #2607

Closed
avokin2 opened this issue Sep 5, 2022 · 1 comment
Closed

Support diff view for failed assertEqual condition in Intelij IDEA #2607

avokin2 opened this issue Sep 5, 2022 · 1 comment

Comments

@avokin2
Copy link
Contributor

avokin2 commented Sep 5, 2022

I see that cucumber-core team has implemented output formatter for IntelliJ IDEA. Thank you. Now JetBrains doesn't need to ship output formatter for every Cucumber-Java version.

🤔 What's the problem you're trying to solve?

Unfortunatelly built-in formatter (TeamCityPlugin) doesn't provide "expected" and "actual" attributes in cause of failed condition. That's why diff toolwindow is unavailable for cucumber tests.

✨ What's your proposed solution?

It's necessary to add the "expected" and the "actual" attributes to the ##teamcity[testFailed message.

⛏ Have you considered any alternatives or workarounds?

We could ship a new version of output formatter for Cucumber-Java v.7. But I believe it's much better when the TeamCityPlugin built in cucumber-core.

📚 Any additional context?

Issue in IDEA tracker: IDEA-125830


This text was originally generated from a template, then edited by hand. You can modify the template here.

avokin2 pushed a commit to avokin2/cucumber-jvm that referenced this issue Sep 5, 2022
For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message.

This fixes issue: cucumber#2607
@mpkorstanje
Copy link
Contributor

I'm happy to see that this has your attention! Could you please pick up IDEA-276468 so I can get rid of the workarounds for IDEA:

private static final Set<String> INCOMPATIBLE_INTELLIJ_IDEA_PLUGIN_CLASSES;
static {
Set<String> incompatible = new HashSet<>();
incompatible.add("org.jetbrains.plugins.cucumber.java.run.CucumberJvmSMFormatter");
incompatible.add("org.jetbrains.plugins.cucumber.java.run.CucumberJvm2SMFormatter");
incompatible.add("org.jetbrains.plugins.cucumber.java.run.CucumberJvm3SMFormatter");
incompatible.add("org.jetbrains.plugins.cucumber.java.run.CucumberJvm4SMFormatter");
incompatible.add("org.jetbrains.plugins.cucumber.java.run.CucumberJvm5SMFormatter");
INCOMPATIBLE_INTELLIJ_IDEA_PLUGIN_CLASSES = unmodifiableSet(incompatible);
}

avokin2 pushed a commit to avokin2/cucumber-jvm that referenced this issue Sep 9, 2022
For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message.

This fixes issue: cucumber#2607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants