Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support diff toolwindow in IntelliJ IDEA #2608

Merged
merged 10 commits into from
Sep 15, 2022

Conversation

avokin2
Copy link
Contributor

@avokin2 avokin2 commented Sep 5, 2022

For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message.

This fixes issue: #2607

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the main points. However I do feel some important details are missing and the test coverage is a bit spotty.

Please also update the CHANGELOG.md and run mvn spotless:apply to fix the formatting.

For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message.

This fixes issue: cucumber#2607
@avokin2 avokin2 force-pushed the avokin/diff-toolwindow-in-intellij branch from c0c3e35 to f374d01 Compare September 9, 2022 09:33
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #2608 (3e0a702) into main (fe56287) will increase coverage by 0.14%.
The diff coverage is 90.90%.

❗ Current head 3e0a702 differs from pull request most recent head 577d9c8. Consider uploading reports for the commit 577d9c8 to get more accurate results

@@             Coverage Diff              @@
##               main    #2608      +/-   ##
============================================
+ Coverage     84.72%   84.87%   +0.14%     
- Complexity     2696     2699       +3     
============================================
  Files           320      320              
  Lines          9512     9544      +32     
  Branches        908      913       +5     
============================================
+ Hits           8059     8100      +41     
+ Misses         1123     1111      -12     
- Partials        330      333       +3     
Impacted Files Coverage Δ
...n/java/io/cucumber/core/plugin/TeamCityPlugin.java 88.26% <90.90%> (+0.38%) ⬆️
...ucumber/core/runner/PickleStepDefinitionMatch.java 96.05% <0.00%> (+3.94%) ⬆️
...ava/io/cucumber/core/runner/StackManipulation.java 65.51% <0.00%> (+31.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje
Copy link
Contributor

@avokin I've pushed fixes for the suggestions I've made above. That was a bit quicker. Also added support for AssertJ, Testng and JUnit4. That should cover the most common frameworks I think.

@avokin2
Copy link
Contributor Author

avokin2 commented Sep 10, 2022

Thank you!

Should I fix anything else?

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Sep 14, 2022

No, I think this is okay for now. Release will happen soonish.

@mpkorstanje mpkorstanje changed the title Support diff toolwindow in IntelliJ IDEA [Core] Support diff toolwindow in IntelliJ IDEA Sep 15, 2022
@mpkorstanje mpkorstanje merged commit 99c22e1 into cucumber:main Sep 15, 2022
@aslakhellesoy
Copy link
Contributor

Hi @avokin2,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants