[Core] Use UndefinedStepsTracker from provided RuntimeGlue #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2016 18:40
mpkorstanje
reviewed
Jul 7, 2017
| optionalGlue.stepDefinitionMatch("", new Step(null, "Given ", "A", 1, null, null), ENGLISH); | ||
|
|
||
| assertEquals(0x1, runtime.exitStatus()); | ||
| } |
There was a problem hiding this comment.
With the current code base no tests are executed in this test so this won't pass.
mpkorstanje
requested changes
Jul 7, 2017
mpkorstanje
changed the title
|
Nevermind. I just realized this was a PR from 2016! A belated thanks for your contribution. |
mpkorstanje
added a commit
that referenced
this pull request
Jul 7, 2017
Glue only served to pass the UndefinedStepsTracker between Runtime and Runtime. Decoupling this removes some pointless complexity. The constructor `RuntimeGlue(UndefinedStepsTracker tracker, LocalizedXStreams localizedXStreams)` has been deprecated to avoid breaking existing implementations. The Runtime will not use the provided UndefinedStepsTracker but this is consistent with the behaviour prior to #1019. Third parties interested in undefined steps can use the subscribe their own UndefinedStepsTracker to the event bus.
mpkorstanje
added a commit
that referenced
this pull request
Jul 7, 2017
Glue only served to pass the UndefinedStepsTracker between Runtime and Runtime. Decoupling this removes some pointless complexity. The constructor `RuntimeGlue(UndefinedStepsTracker, LocalizedXStreams)` has been deprecated to avoid breaking existing implementations. The Runtime will not use the provided UndefinedStepsTracker but this is consistent with the behaviour prior to #1019. Third parties interested in undefined steps can use the subscribe their own UndefinedStepsTracker to the event bus.
mpkorstanje
added a commit
that referenced
this pull request
Jul 7, 2017
Glue only served to pass the UndefinedStepsTracker between Runtime and Runtime. Decoupling this removes some pointless complexity. The constructor `RuntimeGlue(UndefinedStepsTracker, LocalizedXStreams)` has been deprecated to avoid breaking existing implementations. The Runtime will not use the provided UndefinedStepsTracker but this is consistent with the behaviour prior to #1019. Third parties interested in undefined steps can use the subscribe their own UndefinedStepsTracker to the event bus.
|
The exit code is now not connected at all to the |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed RuntimeGlue and it's tracker is not connected with Runtime and it's tracker.