[Gosu] Fix and re-enable Gosu for 2.0.0 #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
changed the title
mpkorstanje
force-pushed
the
DPUkyle-fix_gosu
branch
from
8eba4a7
to
f321173
Compare
brasmusson
reviewed
Jun 19, 2017
.travis.yml
Outdated
| @@ -19,13 +19,13 @@ cache: | |||
| matrix: | |||
| include: | |||
| - jdk: openjdk7 | |||
| script: mvn -q install -P examples | |||
| script: mvn -q install | |||
There was a problem hiding this comment.
I was more into building the examples in all jobs in the matrix ...
There was a problem hiding this comment.
That will happen now. I've setup the pom in such a way that all modules and projects that can be build, will be build.
Comes to mind I should probably push this change into #1154.
mpkorstanje
force-pushed
the
DPUkyle-fix_gosu
branch
2 times, most recently
from
82c756e
to
c0a1029
Compare
- Gosu runtime now requires Java 8; how can we skip this module when Travis build with openjdk7 or oraclejdk7? - Thanks to @kausnz for supplying the clever reflection solution
mpkorstanje
force-pushed
the
DPUkyle-fix_gosu
branch
from
c0a1029
to
7edd7f1
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable Gosu!
Details
This PR updates Gosu support and re-enables the cucumber-gosu module.
Motivation and Context
Gosu has been broken for a while now, see #874, #1086
How Has This Been Tested?
Existing tests are passing again.
Types of changes
Checklist: