[Core] Add TestRunStarted event, let Stats handle the exit code #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brasmusson
force-pushed
the
add-test-run-started-event
branch
from
2a74b02
to
b14fb34
Compare
mpkorstanje
force-pushed
the
add-test-run-started-event
branch
from
b14fb34
to
2694095
Compare
|
Rebased to resolve conflicts |
mpkorstanje
reviewed
Jul 7, 2017
| @@ -32,50 +27,17 @@ | |||
| */ | |||
| public class Runtime { | |||
|
|
|||
| private static final String[] ASSUMPTION_VIOLATED_EXCEPTIONS = { | |||
Add the TestRunStarted event and present the duration between the TestRunStarted and TestRunFinished events in the summary print out. Move the handling of exit code and errors to the summary print out to the Stats class.
mpkorstanje
force-pushed
the
add-test-run-started-event
branch
from
2694095
to
d8559dc
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add TestRunStarted event, move the exit code handling to the Stats class.
Details
Add the TestRunStarted event and present the duration between the TestRunStarted and TestRunFinished events in the summary print out.
Move the handling of exit code and errors to the summary print out to the Stats class.
Motivation and Context
The duration of a test step is the duration between the TestStepStarted and TestStepFinished events. The duration of a test case is the duration between the TestCaseStarted and TestCaseFinished events.
Therefore it is natural that the duration of the test run (presented in the summary print out) is the duration between the TestRunStarted and TestRunFinished events
How Has This Been Tested?
The automated test suite has been updated to verify this behaviour.
Types of changes
Checklist: