Update the version of the cucumber-jvm-deps dependency #1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To make cucumber-android work out of the box, update the cucumber-jvm-deps dependency to a version which includes non Java8 classes (using bytecode major version 52).
Details
This RP depends on a new cucumber-jvm-deps release which includes the downgrading of the xstream version to v1.4.7. xstream > v1.4.7 includes Java8 classes (using bytecode major version 52), which are used on Jdk8 but cannot be used in an Android dex file.
The cucumber-jvm-deps dependency is updated to v1.0.6 (not released yet).
Also exclude the gherkin-jvm-deps from the gherkin dependency. Since classes from gherkin-jvm-deps is repackaged in the gherkin jar, this is needed to avoid to add the same class twice when creating the binary for running Cucumber-JVM on Android.
Fixes #893.
Motivation and Context
To make cucumber-android work out of the box.
How Has This Been Tested?
The Android-test and Cukeulator-test example project have been successfully executed on an emulated Android device (to be specific neither the Android SDK nor the emulated device, were of the latest version, SDK version: r23.0.2, emulated device version: android v4.4.2 - API level 19).
Types of changes
Checklist: