Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the cucumber-jvm-deps dependency #1170

Merged
merged 2 commits into from
Jul 15, 2017

Conversation

brasmusson
Copy link
Contributor

Summary

To make cucumber-android work out of the box, update the cucumber-jvm-deps dependency to a version which includes non Java8 classes (using bytecode major version 52).

Details

This RP depends on a new cucumber-jvm-deps release which includes the downgrading of the xstream version to v1.4.7. xstream > v1.4.7 includes Java8 classes (using bytecode major version 52), which are used on Jdk8 but cannot be used in an Android dex file.

The cucumber-jvm-deps dependency is updated to v1.0.6 (not released yet).

Also exclude the gherkin-jvm-deps from the gherkin dependency. Since classes from gherkin-jvm-deps is repackaged in the gherkin jar, this is needed to avoid to add the same class twice when creating the binary for running Cucumber-JVM on Android.

Fixes #893.

Motivation and Context

To make cucumber-android work out of the box.

How Has This Been Tested?

The Android-test and Cukeulator-test example project have been successfully executed on an emulated Android device (to be specific neither the Android SDK nor the emulated device, were of the latest version, SDK version: r23.0.2, emulated device version: android v4.4.2 - API level 19).

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@brasmusson brasmusson added this to the 2.0.0 milestone Jul 7, 2017
Since classes from gherkin-jvm-deps is repackaged in the gherkin jar,
this is needed to avoid to add the same class twice when creating the
binary for running Cucumber-JVM on Android.
Also handle that cucumber-jvm-deps has changed groupId.
@brasmusson brasmusson merged commit 2a679c1 into master Jul 15, 2017
brasmusson added a commit that referenced this pull request Jul 15, 2017
@brasmusson brasmusson deleted the android-cucumber-jvm-deps branch July 15, 2017 15:01
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cucumber-JVM v1.2.3 (and v1.2.4) fails to build for Android
1 participant