Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix line filter for scenario outlines #1981

Merged
merged 1 commit into from
May 29, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented May 29, 2020

Broken by #1804. While covered by unit tests, the unit tests were broken by
a change in the way feature identifiers were parsed. When parsing a feature
path relative paths are expanded to full file uris. This resulted in the uri
of the pickle not matching the uri provided by the test. As a result all pickles
were accepted regardless of the filter used.

Fixes: #1980

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Broken by #1804. While covered by unit tests, the unit tests were broken by
a change in the way feature identifiers were parsed. When parsing a feature
path relative paths are expanded to full file uris. This resulted in the uri
of the pickle not matching the uri provided by the test.

Fixes: #1980
@mpkorstanje mpkorstanje force-pushed the core-fix-line-filter-for-scenario-outline branch from c9d416d to 642fa92 Compare May 29, 2020 14:44
@mpkorstanje mpkorstanje marked this pull request as ready for review May 29, 2020 14:46
@coveralls
Copy link

coveralls commented May 29, 2020

Coverage Status

Coverage decreased (-0.007%) to 85.956% when pulling 642fa92 on core-fix-line-filter-for-scenario-outline into 844e8c1 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cucumber: Multiple Scenario Outlines are not getting executed in Cucumber 5.x.x: A possible bug?
2 participants