Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use null safe-messages #2497

Merged
merged 26 commits into from
Apr 19, 2022
Merged

[Core] Use null safe-messages #2497

merged 26 commits into from
Apr 19, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Mar 8, 2022

With cucumber/common#1879 messages now uses
Optional<T> for optional types avoiding some unexpected null references.
This resulted in some updating of gherkin and html-formatter.

Additionally with this change the dependency on Jackson has been removed from
messages. However we still have to serialize the message objects into json.
So for now Jackson is shaded into core instead. And eventually we'll be able
to spin this out to it's own module.

@mpkorstanje mpkorstanje changed the title WIP Use null safe-messages [Core] Use null safe-messages Mar 8, 2022
pom.xml Outdated Show resolved Hide resolved
bom/pom.xml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #2497 (20f1f9d) into main (655eb1f) will increase coverage by 0.60%.
The diff coverage is 97.92%.

@@             Coverage Diff              @@
##               main    #2497      +/-   ##
============================================
+ Coverage     83.80%   84.40%   +0.60%     
+ Complexity     2651     2648       -3     
============================================
  Files           309      310       +1     
  Lines          9360     9324      -36     
  Branches        913      896      -17     
============================================
+ Hits           7844     7870      +26     
+ Misses         1183     1121      -62     
  Partials        333      333              
Impacted Files Coverage Δ
...ava/io/cucumber/core/plugin/TimelineFormatter.java 90.57% <ø> (ø)
...ber/core/gherkin/messages/GherkinMessagesStep.java 61.53% <80.00%> (ø)
...ucumber/core/options/CommandlineOptionsParser.java 80.23% <85.71%> (+37.03%) ⬆️
...main/java/io/cucumber/core/runner/CachingGlue.java 98.15% <96.96%> (-0.95%) ⬇️
...in/java/io/cucumber/core/plugin/HtmlFormatter.java 77.77% <100.00%> (+1.30%) ⬆️
...src/main/java/io/cucumber/core/plugin/Jackson.java 100.00% <100.00%> (ø)
...in/java/io/cucumber/core/plugin/JsonFormatter.java 73.62% <100.00%> (ø)
...java/io/cucumber/core/plugin/MessageFormatter.java 85.71% <100.00%> (ø)
...java/io/cucumber/core/plugin/TestSourcesModel.java 83.20% <100.00%> (+1.31%) ⬆️
...n/java/io/cucumber/core/plugin/UsageFormatter.java 57.14% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655eb1f...20f1f9d. Read the comment docs.

@mpkorstanje mpkorstanje marked this pull request as ready for review April 18, 2022 22:10
@mpkorstanje mpkorstanje merged commit cace210 into main Apr 19, 2022
@mpkorstanje mpkorstanje deleted the use-null-safe-messages branch April 19, 2022 10:16
@aslakhellesoy
Copy link
Contributor

Very nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants