Reporter fix #285
Reporter fix #285
Conversation
It's reporting the appropriate exceptions now, not failures in the formatters.
My maven build still returns a succesful build though. That doesn't seem right.
|
Oh, I didn't bump versions in the pom.xml of either of the pull requests. Wasn't sure exactly how to facilitate that :) |
| if(!monochrome){ | ||
| ANSI_ESCAPES.get(result.getStatus()).appendTo(out); | ||
| } | ||
| out.append("H"); //TODO: H for hook? |
There was a problem hiding this comment.
Maybe B for Before and A for After?
There was a problem hiding this comment.
I thought about that. I figure you won't see these unless there is a failure. And the beginning/end of the list would indicate which hook it is.
I also was concerned that B and A would not be understood to be Before and After, since we use simple . Passing and F Failing for step definitions, not specifically calling out a Given When Then letter.
All that being said, it's easy to change to B/A, and I'm not really opposed to it.
|
See the hook-reporting branch (both cucumber-jvm and gherkin) for the latest on this. Does that work for you? |
|
I'll take a look at it this evening, I hope. Work is insane right now, and then I've been married for 6 years, so time with the wife wins this weekend :) |
|
@dkowis I'll try to make new releases with the |
|
@aslakhellesoy I'll try to make a point of testing a failing hook on it this week. I've been insanely busy and will be this week and next. Then I have time to breathe again :( |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request depends on cucumber/gherkin#174
This is the cucumber JVM side of things that brings it up to date to work with the changes implemented in the aforementioned pull request.
One thing I'm not sure if it's a consequence of the activity or if more refactoring will be needed:
The build doesn't fail. Maven reports a successful build even though, in my case, every scenario fails (spring context failed to load.) There must be something that's not triggered during the before hook execution to get the scenario execution to remember that it completely bombed. Looking at the previous code, there wasn't anything there in the first place, so it probably only died because the formatter died. I'll look at it again.