Cucumber scala tweaks #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a second level for aggregation of shared items, sources, dependencies, and build plugins. Then the individual projects actually produce the artifacts, using the properties defined in the parent level. (Could probably pull those up entirely, since the project names describe what scala version we're using.) This is a bit more descriptive than before, since we're almost into scala 2.12.
I think it makes more sense to set them in the individual projects.
|
Hm, I just realized that the example project is using the parameter for the "scala current version" Opinions on just using a 2.11.6 fixed value for it instead? Otherwise, I should have three example projects one for each scala version and I think that's silly. |
|
+1 Very neat! Regarding the example, I had the same thought. Either the scala binary version (2.11) should be computed from scala.latest.version (and in Maven it's just overkill) or it should be independent. I would hardcode 2.11.6 as you suggested. At least if we forget to update the example pom it will be correct and in sync. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes as to how the cucumber-scala artifacts are created.
Specifically, now it's a hierarchy of maven poms, with a second aggregator used to build the individual projects, and the shared sources moved into a sources directory.
Additionally I'm using
pluginManagementto avoid copy/pasta for the plugins that generate the I18n sources and the actual building of scala itself. The only dependencies listed in the scala_ projects are the scala versions themselves. This is far more scalable than "current" and "previous" we had before, and it makes it easier to know obviously which version of scala we're building against.I also fixed one compile time flag, since it was talking about using scala 2.9 and we're only building for 2.10 and above.
Finally, I added the milestone of scala 2.12 in there, because I wanted to see it build us an artifact for it :D