Use new tag negation syntax everywhere #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -33,7 +33,7 @@ end | |||
| # DatabaseCleaner.strategy = :truncation | |||
| # end | |||
| # | |||
| # Before('~@no-txn', '~@selenium', '~@culerity', '~@celerity', '~@javascript') do | |||
| # Before('no @no-txn', 'no @selenium', 'no @culerity', 'no @celerity', 'no @javascript') do | |||
There was a problem hiding this comment.
Just to confirm: Is no a valid negation prefix? I haven't been able to find it in tag-expressions-ruby.
There was a problem hiding this comment.
No, no is not a negation prefix. It should be not.
There was a problem hiding this comment.
@xtrasimplicity thanks for the keen eye!
mvz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old tag negation syntax was left in a few places. This replaces them with the new syntax.
This is WIP because it depends on #372 which touches some of the same lines.
Motivation and Context
Fixes remaining causes of #346.
How Has This Been Tested?
Existing tests should still pass.
Types of changes
Checklist: