Update aruba requirement from ~> 1.0 to ~> 2.1

[dependabot]

Updates the requirements on aruba to permit the latest version.

Changelog

Sourced from aruba's changelog.

[2.1.0] / 2022-05-20

• Support Cucumber 8 (#870 by [mvz] with [dependabot])

[2.0.1] / 2022-04-22

• Various cleanups of internal APIs (#838 by [mvz])
• Make objects not pretend to be nil (#843 by [mvz])
• Remove experimental variables replacement feature (#846 by [mvz])
• Support Ruby 3.1 (#850 by [mvz])
• Fix steps that wait for output from commands (#856 by [mvz])
• Ensure Gem.win_platform? is available (#858 by [mvz])
• Support JRuby 9.3 (#867 by [mvz])

[2.0.0] / 2021-07-26

Potentially breaking changes:

• Bump miminum cucumber version to 4 (#814 by [mvz])
• Drop support for Ruby 2.4 (#820 by [mvz])
• Remove deprecated ability to append to non-existent file (#829 by [mvz])
• Make absolute file name warning an error (#783 by [mvz])

Other changes

• Use Ruby's built-in windows platform detection (#813 by [mvz])
• Update some step definitions to use Cucumber Expression syntax (#822 by [mvz])
• Update cucumber dependency to allow use of cucumber 7 (#828 by [dependabot])

[1.1.2] / 2021-06-20

• Add Bundler as an explicit runtime dependency (#810 by [luke-hill])

[1.1.1] / 2021-05-14

• Loosen dependency on the contracts gem (#804 by [mvz])

[1.1.0] / 2021-04-14

• Add step and API to add whole lines to a file (#780 by [mvz])
• Deprecate file creation when using append_to_file (#781 by [mvz])
• Update dependencies to cucumber to allow working with incoming major versions (#801 by [mattwynne])

[1.0.4] / 2021-01-04

• Update rubocop and fix new offenses (various pull requests)
• Turn off Cucumber publish warning in CI (#737 by [olleolleolle])
• Move CI from Travis CI to GitHub Actions (#738 by [mvz])
• Remove superfluous :each from before hooks in RSpec-related cucumber

... (truncated)

Commits

• e6edc69 Prepare version 2.1.0 for release
• ba54535 Merge pull request #870 from cucumber/dependabot/bundler/cucumber-gte-4.0-and...
• aef6d5d Test with cucumber 8 in CI
• 64897ff Add appraisal for Cucumber 8
• 726109c Update cucumber requirement from >= 4.0, < 8.0 to >= 4.0, < 9.0
• d5bd6e3 Merge pull request #869 from cucumber/fix-new-rubocop-offenses
• 3920ad8 Autocorrect Lint/NonDeterministicRequireOrder
• 16e44ee Autocorrect Style/EnvHome
• fa023da Ensure use of RuboCop version supporting TargetRubyVersion 2.5
• 4936a34 Prepare version 2.0.1 for release
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[olleolleolle]

Right, so there is a version requirement that's too steep for the older Railses:

Bundler could not find compatible versions for gem "cucumber":
In rails_5_0.gemfile:
cucumber (< 4)

  aruba (~> 2.1) was resolved to 2.1.0, which depends on
    cucumber (< 9.0, >= 4.0)

[luke-hill]

Yip. It's going to take some time to get all of these things in. I'm going to try tackle them in a specific order. aruba and rubocop-rspec last, rubocop/performance first.

[luke-hill]

This will need a bit of thought. Leave it with me for a few days

[BrianHawley]

@luke-hill you might consider changing the aruba requirement to:

s.add_development_dependency('aruba', '>= 1.0', '< 3')

It's a test-only requirement, so it would be easy to just make the test suite compatible with both versions of aruba. It looks to me like the only difference is that the tests are using a file without the step of creating the file, and that can be fixed in 1 as well so it no longer gives a warning there. Running the tests with aruba 2 in at least the supported combinations would help diagnose and fix the warnings the suite generates now with aruba 1.

This would be a much better solution than dropping supported Rails versions.

However, I wasn't able to easily track down why cucumber is restricted to versions < 4 on Rails 5.0 (in this repo only), as the PR that added that restriction didn't come with an explanation of why. I checked the shared dependencies and they all should work. What happens when you try to run cucumber 4 with rails 5.0? Or is the cucumber dependency restriction in the rails gemfiles just a way to test against different cucumber versions that cucumber-rails supports?

[BrianHawley]

I did a better version of this fix in #552.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.